Skip to content

Commit

Permalink
Fix a typo :)
Browse files Browse the repository at this point in the history
that elements are -> those elements are
  • Loading branch information
mizukick authored and freak4pc committed Mar 3, 2020
1 parent fad737f commit f62c4cd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 10 deletions.
14 changes: 5 additions & 9 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,17 @@ All notable changes to this project will be documented in this file.

**Note 2**: Starting with RxSwift 6.x, RxSwift will no longer follow Swift versioning. Meaning, RxSwift can possibly move to v6, v7 or v8 while Swift itself is still in 5.x.

* Add `ReplayRelay`. #2109
* Minimum Swift version is now 5.1. #2077
* Remove scoped imports in favor of library evolution. #2103
* `Reactive` now uses `@dynamicMemberLookup` to provide automatic binders for most properties. #2110
* Add `ReplayRelay`. #2109
* `Binder` is now part of RxSwift itself, instead of RxCocoa only. #2110
* Add `SharedSequence` conformance to `ObservableConvertibleType`. #2019
* Add `ObservableConvertibleType` conformance to `SharedSequence`. #2019
* Add `onDisposed` closure argument to `subscribe` on `Maybe`, `Completable` and `Single`. #1977
* Remove `UIWebView` Reactive Extensions due to Apple hard deprecation. #2062
* Fix `DelegateProxy` call to `layoutIfNeeded` for an object without a window. #2076
* Minimum Swift version is now 5.1. #2077
* Remove scoped imports in favor of library evolution. #2103
* Add `Driver.drive()` and `Signal.emit()` for multiple observers/relays. #1962
* Add `compactMap` to `SharedSequence`, `Single` and `Maybe`. #1978
* Add `UITextField.isSecureTextEntry` binder. #1968
* Remove "custom" `Result` in favor of `Foundation.Resault`. #2006
* Fix compilation error in `SharedSequence.createUnsafe`. #2014
* Added `defaultValue` to `sample` to be returned when no new events occur between sampler ticks. #1457
* Change return type of `didFinishPickingMediaWithInfo` Reactive Extension.

## [5.1.0](https://github.com/ReactiveX/RxSwift/releases/tag/5.1.0)

Expand Down
2 changes: 1 addition & 1 deletion Documentation/DesignRationale.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ But OK, let's ignore that and assume we can use that to model sequences that don

Well yes, it potentially could be, but let's consider why you would want to use sequences that don't error out.

One obvious application would be for permanent streams in the UI layer that drive the entire UI. When you consider that case, it's not really sufficient to only use the compiler to prove that sequences don't error out, you also need to prove other properties. For instance, that elements are observed on `MainScheduler`.
One obvious application would be for permanent streams in the UI layer that drive the entire UI. When you consider that case, it's not really sufficient to only use the compiler to prove that sequences don't error out, you also need to prove other properties. For instance, those elements are observed on `MainScheduler`.

What you really need is a generic way to prove traits for observable sequences. There are a lot of properties you could be interested in. For example:

Expand Down

0 comments on commit f62c4cd

Please sign in to comment.