-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: merge main back to dev #11232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: office xml addin string and readme * refactor: office xml addin string and readme
* fix: add treeview telemetry rebase to main branch * fix: delete telemetry test env variable * refactor: added common isOfficeAddin property * fix: replace isOfficeAddin by officeProjectType * fix: remove telemetry test configuration * fix: remove unused err from officeDevHandlers * fix: remove useless initialization of 'officeProjectType' property * fix: change officeProjectType to officecAddinProjectType --------- Co-authored-by: Ruiqi Yang (from Dev Box) <[email protected]>
build(release): merge dev into main branch
…lag (#11145) Co-authored-by: Ruiqi Yang (from Dev Box) <[email protected]>
* split different task to separate terminal * fix manifest * fix string content
feat: force the feature OfficeAddin to close[MetaOS]
- @microsoft/[email protected] - @microsoft/[email protected] - @microsoft/[email protected] - @microsoft/[email protected] - [email protected] - [email protected]
This reverts commit eadc683.
build: revert version change
fix: retire error-message
fix: create project static options
…eXMLAddin refactor: disable create office xml addin
build: merge hotfix/wxp-mar to main
LongOddCode
requested review from
jayzhang,
tecton,
swatDong and
timngmsft
as code owners
March 29, 2024 07:34
LongOddCode
requested review from
sffamily,
therealjohn,
supkasar,
1openwindow,
HuihuiWu-Microsoft,
nliu-ms,
xzf0587,
yuqizhou77,
blackchoey,
wenytang-ms,
KennethBWSong,
hund030,
chagong and
Alive-Fish
as code owners
March 29, 2024 07:34
@@ -6,6 +6,7 @@ | |||
import { TOOLS, globalVars } from "../core/globalVars"; | |||
import { ProjectTypeResult } from "./projectTypeChecker"; | |||
import { assign } from "lodash"; | |||
import { ProjectType } from "@microsoft/m365-spec-parser"; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Unused import ProjectType.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #11232 +/- ##
==========================================
+ Coverage 87.24% 87.26% +0.02%
==========================================
Files 458 458
Lines 27903 27942 +39
Branches 5613 5617 +4
==========================================
+ Hits 24343 24383 +40
Misses 1788 1788
+ Partials 1772 1771 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.