Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: merge hotfix/wxp-mar to main #11231

Merged
merged 23 commits into from
Mar 29, 2024
Merged

build: merge hotfix/wxp-mar to main #11231

merged 23 commits into from
Mar 29, 2024

Conversation

LongOddCode
Copy link
Contributor

No description provided.

ZYUN-MSFT and others added 23 commits March 21, 2024 11:43
* refactor: office xml addin string and readme

* refactor: office xml addin string and readme
* fix: add treeview telemetry rebase to main branch

* fix: delete telemetry test env variable

* refactor: added common isOfficeAddin property

* fix: replace isOfficeAddin by officeProjectType

* fix: remove telemetry test configuration

* fix: remove unused err from officeDevHandlers

* fix: remove useless initialization of 'officeProjectType' property

* fix: change officeProjectType to officecAddinProjectType

---------

Co-authored-by: Ruiqi Yang (from Dev Box) <[email protected]>
* split different task to separate terminal

* fix manifest

* fix string content
feat: force the feature OfficeAddin to close[MetaOS]
…eXMLAddin

refactor: disable create office xml addin
Copy link

Fx-core feat commits:
feat: force the feature to close ba61f01

CLI feat commits:

Extension-toolkit feat commits:

SDK feat commits:

SDK React feat commits:

.Net SDK feat commits:

Fx-core fix commits:
fix: create project static options f0239d9
fix: retire error-message e36a032
fix: ci failure (#11149) c210cfe
fix: fix officeProjectAddin error and enable officeXMLAddin feature flag (#11145) 4b85bfb
fix: add treeview telemetry rebase to main branch (#11087) 9f6f958

CLI fix commits:

Extension-toolkit fix commits:
fix: split different task to separate terminal (#11090) 2826ebe
fix: add treeview telemetry rebase to main branch (#11087) 9f6f958

SDK fix commits:

SDK React fix commits:

.Net SDK fix commits:

@@ -6,6 +6,7 @@
import { TOOLS, globalVars } from "../core/globalVars";
import { ProjectTypeResult } from "./projectTypeChecker";
import { assign } from "lodash";
import { ProjectType } from "@microsoft/m365-spec-parser";

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import ProjectType.
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 92.64706% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.21%. Comparing base (61afc97) to head (e5641e2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11231      +/-   ##
==========================================
+ Coverage   87.19%   87.21%   +0.02%     
==========================================
  Files         457      457              
  Lines       27569    27608      +39     
  Branches     5528     5531       +3     
==========================================
+ Hits        24038    24078      +40     
  Misses       1776     1776              
+ Partials     1755     1754       -1     
Files Coverage Δ
packages/fx-core/src/common/featureFlags.ts 97.67% <100.00%> (+0.05%) ⬆️
packages/fx-core/src/common/telemetry.ts 98.09% <100.00%> (-0.02%) ⬇️
...omponent/generator/officeXMLAddin/projectConfig.ts 100.00% <ø> (ø)
packages/fx-core/src/error/script.ts 100.00% <ø> (ø)
packages/fx-core/src/question/create.ts 91.72% <100.00%> (+0.05%) ⬆️
...-core/src/question/options/CreateProjectOptions.ts 100.00% <ø> (ø)
packages/vscode-extension/src/officeDevHandlers.ts 95.08% <100.00%> (+0.79%) ⬆️
...code-extension/src/telemetry/extTelemetryEvents.ts 100.00% <100.00%> (ø)
...rc/component/generator/officeXMLAddin/generator.ts 98.24% <91.66%> (+9.78%) ⬆️
packages/fx-core/src/common/projectTypeChecker.ts 89.54% <50.00%> (-2.19%) ⬇️

@MSFT-yiz MSFT-yiz merged commit 172bf0e into main Mar 29, 2024
18 of 19 checks passed
@MSFT-yiz MSFT-yiz deleted the long/fork-main branch March 29, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants