fix: retire error-message #11190
Merged
fix: retire error-message #11190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayzhang
requested review from
blackchoey,
wenytang-ms,
KennethBWSong and
adashen
as code owners
blackchoey
reviewed
Mar 26, 2024
| expect(endTelemetry.properties["error-message"]).to.equal( | ||
| 'A http client error happened while performing the aadApp/create task. The error response is: {"error":{"code":"Request_BadRequest","message":"Invalid value specified for property \'displayName\' of resource \'Application\'."}}' | ||
| ); | ||
| // expect(endTelemetry.properties["error-message"]).to.equal( |
There was a problem hiding this comment.
will there be another property to store error message?
There was a problem hiding this comment.
We will use another property name after we can make sure that the error message is in our total control. Retire this for now.
jayzhang
requested review from
1openwindow,
HuihuiWu-Microsoft,
nliu-ms and
tecton
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix/wxp_mar #11190 +/- ##
==================================================
- Coverage 87.15% 87.15% -0.01%
==================================================
Files 456 456
Lines 27507 27503 -4
Branches 5522 5520 -2
==================================================
- Hits 23974 23970 -4
Misses 1774 1774
Partials 1759 1759
|
chagong
approved these changes
Mar 26, 2024
blackchoey
approved these changes
Mar 26, 2024
tecton
approved these changes
Mar 27, 2024
xzf0587
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/27316534
retire
error-message,inner-error,error-stackproperty in telemetry for now and we will use another property name forerror-messageafter we can make sure the content will not contains any 3rd party message.