Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: office xml addin telemetry and teamsapp.yml logic #11055

Conversation

ZYUN-MSFT
Copy link
Contributor

@ZYUN-MSFT ZYUN-MSFT commented Mar 12, 2024

This PR doing the follow things:

  1. add telemetry for Office XML Addin Generator
  2. Add teamsapp.yml for create Office XML Addin
  3. Dynamic Generate Lang Options for Office XML Addin
  4. Comments in FeatureFlag file
  5. Rename Excel Custom Functions capability options (used in CLI)
  6. UT added

For GDPR status, run entityname like 'ms-teams-vscode-extension/office-xml-addin%' and complete = 'true' in GDPR site

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.15%. Comparing base (e3e9eda) to head (b63a921).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11055      +/-   ##
==========================================
+ Coverage   87.13%   87.15%   +0.02%     
==========================================
  Files         456      456              
  Lines       27463    27474      +11     
  Branches     5516     5520       +4     
==========================================
+ Hits        23929    23945      +16     
+ Misses       1774     1770       -4     
+ Partials     1760     1759       -1     
Files Coverage Δ
packages/fx-core/src/common/featureFlags.ts 97.50% <100.00%> (ø)
...omponent/generator/officeXMLAddin/projectConfig.ts 100.00% <ø> (ø)
packages/fx-core/src/question/create.ts 91.61% <100.00%> (+0.06%) ⬆️
...-core/src/question/options/CreateProjectOptions.ts 100.00% <ø> (ø)
...rc/component/generator/officeXMLAddin/generator.ts 98.24% <91.66%> (+9.78%) ⬆️

@ZYUN-MSFT ZYUN-MSFT changed the title User/zyun/office xml addin telemetry refactor: office xml addin telemetry and teamsapp.yml logic Mar 12, 2024
@ZYUN-MSFT ZYUN-MSFT marked this pull request as ready for review March 12, 2024 11:54
jayzhang
jayzhang previously approved these changes Mar 12, 2024
hund030
hund030 previously approved these changes Mar 13, 2024
@ZYUN-MSFT ZYUN-MSFT changed the base branch from dev to main March 14, 2024 01:59
@ZYUN-MSFT ZYUN-MSFT dismissed stale reviews from hund030 and jayzhang March 14, 2024 01:59

The base branch was changed.

@ZYUN-MSFT ZYUN-MSFT changed the base branch from main to dev March 14, 2024 02:01
@ZYUN-MSFT ZYUN-MSFT force-pushed the user/zyun/officeXMLAddinTelemetry branch from 5040f9e to 771807e Compare March 14, 2024 04:33
@ZYUN-MSFT ZYUN-MSFT changed the base branch from dev to main March 14, 2024 06:58
@ZYUN-MSFT ZYUN-MSFT force-pushed the user/zyun/officeXMLAddinTelemetry branch from bb227f0 to 1a832e0 Compare March 14, 2024 06:59
@ZYUN-MSFT ZYUN-MSFT force-pushed the user/zyun/officeXMLAddinTelemetry branch 2 times, most recently from 664beef to 5aa6462 Compare March 15, 2024 08:49
jayzhang
jayzhang previously approved these changes Mar 15, 2024
hund030
hund030 previously approved these changes Mar 15, 2024
@ZYUN-MSFT ZYUN-MSFT dismissed stale reviews from hund030 and jayzhang via b341485 March 18, 2024 02:58
@ZYUN-MSFT ZYUN-MSFT force-pushed the user/zyun/officeXMLAddinTelemetry branch 4 times, most recently from e893350 to 68a280e Compare March 20, 2024 07:27
@ZYUN-MSFT ZYUN-MSFT force-pushed the user/zyun/officeXMLAddinTelemetry branch from 68a280e to b63a921 Compare March 20, 2024 07:57
@ZYUN-MSFT ZYUN-MSFT changed the base branch from main to wxp/mar_release March 21, 2024 03:18
@jayzhang jayzhang merged commit e5e01ea into OfficeDev:wxp/mar_release Mar 21, 2024
23 of 25 checks passed
@ZYUN-MSFT ZYUN-MSFT deleted the user/zyun/officeXMLAddinTelemetry branch March 25, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants