MYNN-EDMF updates and bug fixes

[joeolson42]

Updates and bug fixes include:

1. two bug fixes in code that are not used in realtime configurations (i.e. test/development configurations like mixing smoke or additional diagnostic output enabled). This does however reduce the memory allocated in any configuration.

2. Change upper BC in the TKE solver from "no flux" to "prescribed" - fixed a crash with a strong jet near the model top.

3. Config changes made to Pr limit (5 to 10)

4. Config changes to entrainment in mass-flux component (to Neggers 2015 form) - allows for the removal of some code that constrained accelerating plumes.

[climbfuji]

Associated PRs:

#102
NOAA-GSL/fv3atm#103
NOAA-GSL/ufs-weather-model#97

For regression testing, see NOAA-GSL/ufs-weather-model#97

[climbfuji]

@joeolson42 FYI the runtimes of the tests increased recently on Hera, not sure if it is because of your PR or the system being slow in general. I need to adjust the forecast length and wallclock time of a few tests for GNU, but other than that the PR looks good.

[joeolson42]

It could be due to the mixing length change. The switch to use the non-local form (now with bl_mynn_mixlength = 1 or 2) will be a little more expensive.

…

On Mon, Aug 9, 2021 at 11:00 AM Dom Heinzeller ***@***.***> wrote: @joeolson42 <https://github.com/joeolson42> FYI the runtimes of the tests increased recently on Hera, not sure if it is because of your PR or the system being slow in general. I need to adjust the forecast length and wallclock time of a few tests for GNU, but other than that the PR looks good. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADLRR3SUQZLAEINZTPKCTBTT4ACSNANCNFSM5BPZG2NQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

-- Joseph Olson Model Physics Branch Chief Environmental Prediction Advancement Division NOAA-Global Systems Laboratory Boulder, Colorado

[climbfuji]

It could be due to the mixing length change. The switch to use the non-local form (now with bl_mynn_mixlength = 1 or 2) will be a little more expensive.
…

I am suspicious about hera. The code is MUCH slower, not just a little.

[DomHeinzeller]

Code changes look good, runtime is about the same as before, and regression tests pass.

[joeolson42]

thanks Dom

…

On Wed, Aug 11, 2021 at 11:03 AM DomHeinzeller ***@***.***> wrote: Merged #102 <#102> into gsl/develop. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADLRR3XSBRKA7I7D2AQGVQTT4KUOZANCNFSM5BPZG2NQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

-- Joseph Olson Model Physics Branch Chief Environmental Prediction Advancement Division NOAA-Global Systems Laboratory Boulder, Colorado