Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Flake model with RUC LSM in FV3_HRRR and FV3_GSD_v0 suites. Bug fixes for fractional grid. #103

Merged

Conversation

tanyasmirnova
Copy link
Collaborator

@tanyasmirnova tanyasmirnova commented Aug 16, 2021

  1. Changes for fracional grid (frac_grid=.true.)
  2. Replace logical variable for lakes from 'lake' to 'use_flake' in sfc_drv_ruc.F90.
  3. Added call to Flake to FV3_HRRR and FV3_GSD_v0 suites.
  4. Added spp code from WRF version of RUC LSM in case it would be needed
    for RRFS. So far it is not hooked up to SPP weights and not changing the results.

Associated PRs:

NOAA-GSL/fv3atm#105
#103
NOAA-GSL/ufs-weather-model#99

See NOAA-GSL/ufs-weather-model#99 for code review and testing

2. Replace logical variable for lakes from 'lake' to 'use_flake'
3. Added spp code from WRF version of RUC LSM in case it would be needed
for RRFS. So far it is not hooked up to SPP weights.
@tanyasmirnova tanyasmirnova changed the title Bug fixes for the fractgional grid and the use of Flake model with RUC LSM. Use the Flake model with RUC LSM in FV3_HRRR and FV3_GSD_v0 suites. Bug fixes for fractional grid. Aug 16, 2021
Copy link

@DomHeinzeller DomHeinzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, and all regression tests passed.

@DomHeinzeller DomHeinzeller merged commit 8c02067 into NOAA-GSL:gsl/develop Aug 23, 2021
zhanglikate pushed a commit to zhanglikate/ccpp-physics that referenced this pull request Mar 1, 2024
Fixes to allow FV3_HRRR_c3 to run with gnu debug plus PR NOAA-GSL#113, NOAA-GSL#106, and NOAA-GSL#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants