Update gsl/develop from main 2021/09/21

[climbfuji]

Description

Update gsl/develop from main as of 2021/09/21. Changes in this PR:

• Update of cmake build system files
• Metadata bugfixes
• Bugfix in physics/sfcsub.F for coupled runs w/ fractional landmask

Testing

See NOAA-GSL/ufs-weather-model#102

Associated PRs

NOAA-GSL/ccpp-framework#18
#106
NOAA-GSL/fv3atm#108
NOAA-GSL/ufs-weather-model#102

[DomHeinzeller]

@tanyasmirnova @joeolson42 for your information. No changes that you need to be concerned with, as far as I know.

[tanyasmirnova]

I think that with a fractional grid it is better not to use slmsk.

[climbfuji]

This is testing for slmskl, not slmsk - do you think this is also a problem with fractional grids?

[tanyasmirnova]

@DomHeinzeller Dom, slmskl is computed in gcycle.F90, and this computation looks questionable to me. But I assume that people who wrote the code tested it with frac_grid=.true. Therefore, I approved this PR.

[climbfuji]

@SMoorthi-emc wrote the code and I am highly confident that he tested the logic with fractional grid turned on. Moorthi, can you confirm that the above code change in sfcsub.F works with fractional grid as intended? Thanks!

[SMoorthi-emc]

Dom, This code is specifically important for fractional grid. The way "slmsk" is interpreted in the code is that it is "0" for points with all water, it is "1" if there is any land and it is "2" if there is ice and no land. Unfortunately, that is what it is right now unless someone is willing to rewrite most of the code. "slmskl" in gcycle is "1" if there is any "land" and "slmskw" is "0" if there is any water. However, if there is land/water/ice in a grid, then "slmsk=1" and not "2". Please note that in this case "slmskl=1" and "slmskw=0". I hope this helps. Moorthi

…

On Wed, Sep 22, 2021 at 12:55 PM Dom Heinzeller ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In physics/sfcsub.F <#106 (comment)>: > @@ -2019,12 +2019,14 @@ subroutine sfccycle(lugb,len,lsoil,sig1t,deltsfc & ! *,' tsffcs=',tsffcs(iprnt),' slianl=',slianl(iprnt) do i=1,len + if (nint(slmskl(i)) /= 1) then if (sicanl(i) >= min_ice(i)) then @SMoorthi-emc <https://github.com/SMoorthi-emc> wrote the code and I am highly confident that he tested the logic with fractional grid turned on. Moorthi, can you confirm that the above code change in sfcsub.F works with fractional grid as intended? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#106 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYTHKY5GE2X2W4CELR3UDIC77ANCNFSM5EPXU3QA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[climbfuji]

Dom, This code is specifically important for fractional grid. The way "slmsk" is interpreted in the code is that it is "0" for points with all water, it is "1" if there is any land and it is "2" if there is ice and no land. Unfortunately, that is what it is right now unless someone is willing to rewrite most of the code. "slmskl" in gcycle is "1" if there is any "land" and "slmskw" is "0" if there is any water. However, if there is land/water/ice in a grid, then "slmsk=1" and not "2". Please note that in this case "slmskl=1" and "slmskw=0". I hope this helps. Moorthi
…

Thanks a lot Moorthi, it does. The subtle difference how slmsk is interpreted is important to know!