MYNN-EDMF updates and bug fixes #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2021
|
The fv3atm hash is correct, this PR has no changes, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update .gitmodules and submodule pointer for fv3atm for code review and testing of the changes in NOAA-GSL/ccpp-physics#102 (MYNN-EDMF updates and bug fixes) from @joeolson42.
Testing
On hera with Intel, create new baselines using
rt_ccpp_dev.confand then verify against them - all tests pass.rt_ccpp_dev_hera_intel_create.log
rt_ccpp_dev_hera_intel_verify.log
On hera with GNU, create new baselines using
rt_ccpp_dev.confand then verify against them - all tests pass.rt_ccpp_dev_hera_gnu_create.log
rt_ccpp_dev_hera_gnu_verify.log
On hera with Intel, verify against existing baselines and make sure that all tests run to completion and only those fail with b4b mismatches that we expect to fail - correct.
rt_hera_intel_verify_against_existing.log
rt_hera_intel_verify_against_existing_fail_test.log
On hera with GNU, verify against existing baselines and make sure that all tests run to completion and only those fail with b4b mismatches that we expect to fail - correct.
rt_hera_gnu_verify_against_existing.log
rt_hera_gnu_verify_against_existing_fail_test.log
Dependencies
NOAA-GSL/ccpp-physics#102
NOAA-GSL/fv3atm#103
#97