CCPP Framework Meeting Minutes 2024 04 01

Agenda

• GitHub issues/PRs
• Code management topics
• New items
• Updates
• Other business
• notes

---

Attendees: Mike Kavulich,

Code management topics

Two PRs were merged (by me) without being fully tested

• https://github.com/NCAR/ccpp-framework/pull/548
• https://github.com/NCAR/ccpp-framework/pull/551

We need a written procedure for when PRs should be merged

• Current Wiki instructions are horribly out-of-date, should be updated

• Ideally, there should be some sort of real indication on a framework PR for when it is actually ready to be merged.

  • Label?
  • Manual comments?
  • Can it be automated somehow?

• Or, as suggested by Courtney (https://github.com/NCAR/ccpp-framework/issues/553), a develop branch where things go after framework tests pass and PR is approved, and then a main branch subject to a different development process

• [Courtney] (related to https://github.com/NCAR/ccpp-framework/issues/553) - how do we approach tagging in CCPP-framework? Some thoughts from meeting with Dustin/Dom/Steve/Courtney:

  • NCAR proposal was to tag all PR commits - too often?
  • only tag when we need them? with strict naming conventions so we can "filter" them out easily from tag list
  • only main branch tagged? develop branch uses hashes?
  • do tags need to (sometimes?) specify the host it's for?
  • when does review happen? develop? and then also main? just main - or would that review be too long?

GitHub issues/PRs

CCPP Framework (issues, PRs, discussions)

• PR 523: Add support to use mpi_f08 MPI module
  • Merged, MPI now required for code using latest framework
• Issue 543: Remove run phase requirement from capgen
  • PR now open: Add support for scheme w/o run phase
  • Merged
• Issue 540: ccpp_prebuild: (re-)introduce optional attribute
• Issue 547: Post capgen unification: pylint code
  • Still a good idea
• PR 549: Constituent updates

Standard names (issues, PRs, discussions)

• Issue 26: Units for relative humidity
  • Will open PR discussed last week soon
• Issue 57: Feedback on the meaning of: sea_ice_area_fraction_of_sea_area_fraction
  • Waiting to hear back from original author
• Issue 58: Variable name changing policy and procedures
  • Who should we reach out to for adding code ownders?
• Issue 59: New standard names for land surface variables
  • Draft PR: New sub-section and standard names for land surface variables
  • Any suggestions on reviewers?
• Issue 61: Clarification regarding _at_interface suffix

New items for discussion

Updates from last time

Previous notes

Other business

• [Courtney] (related to https://github.com/NCAR/ccpp-framework/issues/553) - how do we approach tagging in CCPP-framework? Some thoughts from meeting with Dustin/Dom/Steve/Courtney:
  • NCAR proposal was to tag all PR commits - too often?
  • only tag when we need them? with strict naming conventions so we can "filter" them out easily from tag list
  • only main branch tagged? develop branch uses hashes?
  • do tags need to (sometimes?) specify the host it's for?
  • when does review happen? develop? and then also main? just main - or would that review be too long?

Meeting notes