Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openmpi install to CI #551

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Add openmpi install to CI #551

merged 6 commits into from
Mar 27, 2024

Conversation

dustinswales
Copy link
Collaborator

This PR adds to the CCPP Prebuild CI test to install open-mpi v4.1.6, which is now a requirement for CCPP.

@dustinswales
Copy link
Collaborator Author

@grantfirl @mkavulich @scrasmussen
Just a heads up.
When the CCPP SCM updates its CCPP Framework hash, all of the CI tests will break until this addition is added to those tests.

@climbfuji
Copy link
Collaborator

That's great! I know this is pedantic but we'll probably want to include that in one of the upcoming ufs prs, even though this clearly doesn't affect anything but CI.

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkavulich mkavulich merged commit 0f416a2 into NCAR:main Mar 27, 2024
6 checks passed
@dustinswales
Copy link
Collaborator Author

@mkavulich This should not have been merged into main. All PRs targeting the main branch need to go through host model testing before getting the okay to merge.

@climbfuji
Copy link
Collaborator

I created ufs-community/ufs-weather-model#2216 to include this change. No need to roll back I think because this PR shouldn't affect anything in the UFS. But let's try to avoid merging into main w/o full testing (see also @peverwhee's issue about creating a develop branch with a smaller testing harness)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants