Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty result #922

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Handle empty result #922

merged 2 commits into from
Apr 24, 2024

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Apr 23, 2024

Related Ticket: #904

Description of Changes

Handle the case when there is no actual value to display from statistics requests.

Notes & Questions About Changes

  • I am not sure the wording is clear. Please feel free to change. It will look like this
Screen Shot 2024-04-23 at 3 24 28 PM
  • Is it valid to assume that if the 'mean' (average) value doesn't exist, then other statistical measures also don't exist?

Validation / Testing

Try datasets that only cover ocean (such as Air-sea co2 flux) , and select aoi that doesn't have ocean coverage.

@hanbyul-here hanbyul-here requested a review from j08lue April 23, 2024 06:31
Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 15a9568
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/66277c22e6e8230008425073
😎 Deploy Preview https://deploy-preview-922--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great we are catching this now.

I made a suggestion for different wording, adding a note to the user what they should do next - please accept, if you see fit.

(Btw, I tested this by analyzing GEOGLAM over the ocean.)

app/scripts/components/exploration/analysis-data.ts Outdated Show resolved Hide resolved
@hanbyul-here hanbyul-here merged commit a841ee0 into main Apr 24, 2024
8 checks passed
@hanbyul-here hanbyul-here deleted the fix/empty-statistics branch April 24, 2024 01:46
@hanbyul-here
Copy link
Collaborator Author

This PR was actually missing a component to display a proper error message, I included it in 7594dd9

hanbyul-here added a commit that referenced this pull request May 1, 2024
## 🎉 Features
- Zoom in AOI, TOI when analysis is run in
#906
- Add custom javascript injection
#846
- ADR for V2 Refactor: #875
- Open all external links in a new tab in
#870
- Include dataset id to filter layers in
#910
- Some datasets can only be analyzed with layers from the same source in
#913
- Create minimal partial data layer scaffold starting off with Data
Catalog for VEDA2 Refactor in
#893
- Add analysis preset in #921

## 🚀 Improvements
- Chart style improvement in
#903
- Data Catalog enhancement with floating filter sidebar in
#918
- Sum as statistics option in
#925
-
## 🐛 Fixes
- Sort featured stories based on publication date in descending order in
#907
- Replace latency with temporalResolution in layer info in
#898
- Add a workaround for Safari scroll problem in
#909
- Handle empty result in #922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants