-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blank time-series chart with some datasets + selected AOI #904
Comments
**Related Ticket:** #904 ### Description of Changes Handle the case when there is no actual value to display from statistics requests. ### Notes & Questions About Changes - I am not sure the wording is clear. Please feel free to change. It will look like this <img width="368" alt="Screen Shot 2024-04-23 at 3 24 28 PM" src="https://github.com/NASA-IMPACT/veda-ui/assets/4583806/f61d052d-850b-4fa4-b97f-c6f89babc692"> - Is it valid to assume that if the 'mean' (average) value doesn't exist, then other statistical measures also don't exist? ### Validation / Testing Try datasets that only cover ocean (such as Air-sea co2 flux) , and select aoi that doesn't have ocean coverage.
@hanbyul-here is this ticket actually complete? I see the merged PR linked above, not sure if it was intentionally left open |
Hmm, in the current production GHG Center, the This layer with no data outside the US shows the expected response: "No data for the selected time range and area of interest." - which @hanbyul-here implemented in the PR above. Perhaps we should have a fresh ticket, in https://github.com/US-GHG-Center/ghgc-backend or so, for the API / data issue we are seeing, and close this one here. |
@j08lue The team has noticed the problem with air-sea co2 data. The ticket is : US-GHG-Center/veda-config-ghg#388 We were not sure why we are getting 500 instead of just empty array, if this looks like a backend issue, please move the ticket to the appropriate place. The original ticket is meant for 'empty statistics' - which we show the correct error message now (No data for the selected time range..), at least for the new exploration page. And we decided not to put any more efforts on old analysis page, so I will say this ticket be closed. |
Description
With some of the datasets, a specific example being the Air Sea CO2 flux in the GHG center, the time series chart values are null even tho the
/search
returns results. See the attached screenshots.This happens when the user draws a polygon on land where the data values don't exist. In such cases, the time-series chart should display a message instead of displaying a blank chart.
All the
/statistics
responses look like this:See an example here: https://earth.gov/ghgcenter/analysis/results?start=2018-01-01T00%3A00%3A00.000Z&end=2022-12-31T00%3A00%3A00.000Z&datasetsLayers=air-sea-co2&aoi=%7C~%60eTwcvbGftcAli%7B%7D%40%7DnohDuhab%40
It will be less of a problem once E&A is out because users can see where data values exist. However, it should still be handled.
Screenshots
The text was updated successfully, but these errors were encountered: