857/chart style #903
857/chart style #903
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
force-pushed
the
857/chart-style
branch
from
083b215 to
cd0667d
Compare
hanbyul-here
force-pushed
the
857/chart-style
branch
from
6596319 to
e3e9f21
Compare
There was a problem hiding this comment.
Great work Hanbyul!
One thing about the tooltip behavior: if someone hovers on the chart there should always be an "active node" so that the tooltip is present, no matter the mouse position. At the moment, it disappears if the mouse position is not near a node. I think that's the reason the little dots on the line charts were included in the first place.
Proposed fix: the tooltip should always be present when hovering over the chart
|
Did a quick lookover, code lgtm 👍🏼 I can re-review again though once updated suggestions are made! |
is still on the timeline but not on the data point anymore
|
@faustoperez I handled the hovering issue 💦 |
|
@hanbyul-here Great job, I wasn't able to replicate the missing tooltip behavior ✊ One thing that's missing is the vertical line on the active node so users have a reference of the hover point, as in the designs. Also, the dots for the St Deviation are missing. Implementation: Designs: Thank you! 💐 |
|
@sandrahoang686 This PR is ready for reviews 🙇 |
|
Looks amazing! 😍 This is a huge improvement to the scientific value of these charts. Please note - labels on the chart value tooltip should be spelled out, please:
|
app/scripts/components/exploration/components/datasets/dataset-chart.tsx
Show resolved
Hide resolved
|
This also closed
|
## 🎉 Features - Zoom in AOI, TOI when analysis is run in #906 - Add custom javascript injection #846 - ADR for V2 Refactor: #875 - Open all external links in a new tab in #870 - Include dataset id to filter layers in #910 - Some datasets can only be analyzed with layers from the same source in #913 - Create minimal partial data layer scaffold starting off with Data Catalog for VEDA2 Refactor in #893 - Add analysis preset in #921 ## 🚀 Improvements - Chart style improvement in #903 - Data Catalog enhancement with floating filter sidebar in #918 - Sum as statistics option in #925 - ## 🐛 Fixes - Sort featured stories based on publication date in descending order in #907 - Replace latency with temporalResolution in layer info in #898 - Add a workaround for Safari scroll problem in #909 - Handle empty result in #922
Related Ticket: #857
Description of Changes
Change new E&A Chart style
Notes & Questions About Changes
Part of #857
The list of changes specified in Figma: https://www.figma.com/file/9INQauBWhiRxvOWDGhRrxO/US-GHG-Center?type=design&node-id=1127-2201&mode=design&t=VNfErIVXtEgHmbZi-0
Question: What should we do for circles that mark the time unit? If I remember correctly, we added it because of the requests from stakeholders.
Validation / Testing
To check the changes, run analysis on this page