Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E & A] Review analysis on new E&A interface #857

Closed
7 of 10 tasks
faustoperez opened this issue Feb 22, 2024 · 8 comments
Closed
7 of 10 tasks

[E & A] Review analysis on new E&A interface #857

faustoperez opened this issue Feb 22, 2024 · 8 comments
Assignees
@hanbyul-here
Labels
ui design
Milestone
E&A Post Release ...

Comments

@faustoperez
Copy link

faustoperez commented Feb 22, 2024 •
edited by aboydnw
Loading

Issue

We are missing the previous selector to enable Max, Min, Avg. etc. metrics on the analysis results due to the new design / implementation. Also, the previous analysis results page included more than one chart.

Acceptance criteria

  • Review and propose a design solution to toggle chart metrics
  • Review expanded dataset panel styles
  • Review how to show multiple charts from a single dataset analysis
  • After triggering an analysis: fly and zoom the map to AOI; zoom the timeline to focus on the selected analysis period
image

Implementation (design linked below)

  • Add timeline chart widgets
  • The chart widget should open up the analysis chart menu
  • When starting an analysis, both map and timeline zoom to selected area
  • Analysis chart lines are updated to design
  • Analysis chart tooltip is updated to design
  • Edgecase behaviors
@faustoperez faustoperez self-assigned this Feb 22, 2024
@faustoperez faustoperez mentioned this issue Feb 28, 2024
Merged
@faustoperez
Copy link
Author

Review and propose a design solution to toggle chart metrics addressed in #860

@faustoperez
Copy link
Author

Related: Review date selection on the timeline #833

@faustoperez
Copy link
Author

Hi, I have updated the Figma file for this ticket.

Link to Figma file 👉 https://www.figma.com/file/9INQauBWhiRxvOWDGhRrxO/US-GHG-Center?type=design&node-id=1127%3A2201&mode=design&t=fGtGK3DblwdZpUGr-1

I am experimenting with a new format for design communication and organization to ensure that each design element is linked to its corresponding issue and the reasoning behind the design is documented. Let me know if this works 👍

image

@faustoperez faustoperez mentioned this issue Mar 11, 2024
Closed
1 task
@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Mar 13, 2024 •
edited
Loading

Note:

  • Download feature available from old analysis view
  • The analysis options including collapser should appear for each layer chart (collapser should be further discussed)
  • When layer chart is zoomed out and there is no space for the analysis options, hide them
  • Menu option colors would change to match new chart styles

@sandrahoang686 sandrahoang686 self-assigned this Mar 19, 2024
This was referenced Mar 24, 2024
Merged
Merged
Merged
hanbyul-here added a commit that referenced this issue Apr 2, 2024
@hanbyul-here
857/chart style (#903)
694a665 
**Related Ticket:** #857 

### Description of Changes
Change new E&A Chart style


### Notes & Questions About Changes
Part of #857
The list of changes specified in Figma:
https://www.figma.com/file/9INQauBWhiRxvOWDGhRrxO/US-GHG-Center?type=design&node-id=1127-2201&mode=design&t=VNfErIVXtEgHmbZi-0
- [x] On the chart, average and standard deviation are shown by default.
- [x] Standard deviation is shown as a grey band around the average
line.
- [x] Median, min and max are optional, accessed through the “Chart
options” icon. (*Unless editor specified which analysis to show)
- [x] Min and max are shown as grey dotted lines.
- [x] The y-axis is shown on the gray area outside the analysis period.
- [x] The y-axis should always show the zero line
- [x] Always expand with yaxis. Get rid of 'collapse' button
- [x] Optional: The chart actions icons are:”Download chart”, “Chart
options” and “Collapse”. Collapse is a local action and collapses the
current chart only. - **only implemented "Chart Options" for now**

Question: What should we do for circles that mark the time unit? If I
remember correctly, we added it because of the requests from
stakeholders.

### Validation / Testing

To check the changes, run analysis [on this
page](https://deploy-preview-903--veda-ui.netlify.app/exploration?datasets=%5B%7B%22id%22%3A%22no2-monthly%22%2C%22settings%22%3A%7B%22isVisible%22%3Atrue%2C%22opacity%22%3A100%2C%22analysisMetrics%22%3A%5B%7B%22id%22%3A%22mean%22%2C%22label%22%3A%22Average%22%2C%22chartLabel%22%3A%22Avg%22%2C%22themeColor%22%3A%22infographicB%22%7D%2C%7B%22id%22%3A%22std%22%2C%22label%22%3A%22St+Deviation%22%2C%22chartLabel%22%3A%22STD%22%2C%22themeColor%22%3A%22infographicD%22%7D%5D%7D%7D%2C%7B%22id%22%3A%22no2-monthly-diff%22%2C%22settings%22%3A%7B%22isVisible%22%3Atrue%2C%22opacity%22%3A100%2C%22analysisMetrics%22%3A%5B%7B%22id%22%3A%22mean%22%2C%22label%22%3A%22Average%22%2C%22chartLabel%22%3A%22Avg%22%2C%22themeColor%22%3A%22infographicB%22%7D%2C%7B%22id%22%3A%22std%22%2C%22label%22%3A%22St+Deviation%22%2C%22chartLabel%22%3A%22STD%22%2C%22themeColor%22%3A%22infographicD%22%7D%5D%7D%7D%5D&date=2023-08-31T15%3A00%3A00.000Z&aois=%5B%22le%7B_Tga%7EbDayfqWpxoNt%60%7EvEl_rpDpuaoJjb%7CsB%22%2C%228cd277%22%2Cfalse%5D&dateRange=2022-08-09T15%3A00%3A00.000Z%7C2023-09-30T15%3A00%3A00.000Z)
hanbyul-here added a commit that referenced this issue Apr 2, 2024
@hanbyul-here
Add TOI zoom behavior (#908)
86bcb09 
**Related Ticket:** #857  

### Description of Changes
Zoom TOI when analysis is run

### Notes & Questions About Changes

Focus on TOI when analysis is run. I meant to separate this PR from
#906, but it was faster to use the structure already set up in #906 to
trigger callback when analysis is run, so this PR builds on top of #906.
This is WIP, but I wanted to run how it behaves with team members.
hanbyul-here added a commit that referenced this issue Apr 3, 2024
@hanbyul-here
Zoom in AOI when analysis is run (#906)
f9b4105 
**Related Ticket:** #857 
### Description of Changes
Zoom aoi when analysis gets run (note that this PR only handles AOI, not
TOI)

### Notes & Questions About Changes

Mapbox has fitBonds problem with some projections:
mapbox/mapbox-gl-js#12565 Because of this
issue, we have to do manual centering which might not look very smooth.
@j08lue j08lue added this to the E&A Further Enhancements milestone Apr 10, 2024
@aboydnw
Copy link
Contributor

aboydnw commented May 17, 2024

@hanbyul-here This looks partially complete, am I interpreting that correctly? Should we break off a new ticket to represent whatever work is incomplete? Might be easier to follow that way.

@hanbyul-here
Copy link
Collaborator

If I remember correctly, we decided to make some changes for R2 and keep the other changes (ex. timeline indicator look & function change) for the next phase. I agree that it might be better to close this ticket and open a new ticket with the leftover items. @faustoperez Do you know if we made a separate ticket for the items that we couldn't tackle for R2?

@faustoperez
Copy link
Author

I don't think we have a separate ticket for the playhead styles and edge case behaviors. The designs would still apply, let me know if there's any support needed on my side 👍

@aboydnw aboydnw mentioned this issue May 30, 2024
Open
1 task
@aboydnw
Copy link
Contributor

aboydnw commented May 30, 2024

I created #986 and I believe the others remaining are covered by #979
Let me know if we are missing an important chunk of work

@aboydnw aboydnw closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanbyul-here hanbyul-here

Labels
ui design
Projects
None yet
Milestone
E&A Post Release Improvements
Development

No branches or pull requests
5 participants
@j08lue @hanbyul-here @faustoperez @sandrahoang686 @aboydnw