Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom javascript tag as a temporary fix for implementing DAP script block for GHG #846

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

amarouane-ABDELHAK
Copy link
Contributor

In response to a memo directing agencies to ensure that GSA’s Digital Analytics Program (DAP) tracking code is installed on all public-facing sites to enable reporting of web traffic metrics, we need to add a custom script tag to the header. This PR allows us to do so by defining two environment variables in the .env file:

CUSTOM_SCRIPT_SRC=<DAP_SRC>
CUSTOM_SCRIPT_ID=<DAP_ID>

Also allows other users to include a custom analytics script.

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 5d49091
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/65cfccda3e897f0008d6deca
😎 Deploy Preview https://deploy-preview-846--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slesaad slesaad requested a review from hanbyul-here February 16, 2024 15:06
@hanbyul-here
Copy link
Collaborator

Can you fix the lint?

@slesaad slesaad merged commit a668d62 into main Feb 19, 2024
8 checks passed
@slesaad slesaad deleted the feature/add-custom-js-script-tag branch February 19, 2024 18:08
hanbyul-here added a commit that referenced this pull request Mar 25, 2024
## 🎉 Features
- Optional media attributes for layers:
#843
- Add custom javascript injection
#846
- ADR for V2 Refactor: #875

## 🚀 Improvements
- E&A imporvement. Related tickets
  - Layer select modal: #845
- Connect dataset information on layer:
#821
  - Layer info modal: #849
- Update data layer card:
#851
  - Hidden layers: #867
- Fast follow-ups: #851 ,
#862,
#863,
#860
  - PR template: #880


## 🐛 Fixes
- Return datasets even when there is a dataset without summaries:
#786
- Show all the datasets on Data Catalog page:
#837
- Block Map user defined position fix:
#784
- Geocoder centering on various projecctions:
#826
- Wording, typo: #869
#854,
#874,
- Fix yaxis labeling: #883
hanbyul-here added a commit that referenced this pull request May 1, 2024
## 🎉 Features
- Zoom in AOI, TOI when analysis is run in
#906
- Add custom javascript injection
#846
- ADR for V2 Refactor: #875
- Open all external links in a new tab in
#870
- Include dataset id to filter layers in
#910
- Some datasets can only be analyzed with layers from the same source in
#913
- Create minimal partial data layer scaffold starting off with Data
Catalog for VEDA2 Refactor in
#893
- Add analysis preset in #921

## 🚀 Improvements
- Chart style improvement in
#903
- Data Catalog enhancement with floating filter sidebar in
#918
- Sum as statistics option in
#925
-
## 🐛 Fixes
- Sort featured stories based on publication date in descending order in
#907
- Replace latency with temporalResolution in layer info in
#898
- Add a workaround for Safari scroll problem in
#909
- Handle empty result in #922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants