-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding custom javascript tag as a temporary fix for implementing DAP script block for GHG #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…script block for GHG
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Can you fix the lint? |
…script block for GHG
…script block for GHG
hanbyul-here
approved these changes
Feb 16, 2024
Merged
hanbyul-here
added a commit
that referenced
this pull request
Mar 25, 2024
## 🎉 Features - Optional media attributes for layers: #843 - Add custom javascript injection #846 - ADR for V2 Refactor: #875 ## 🚀 Improvements - E&A imporvement. Related tickets - Layer select modal: #845 - Connect dataset information on layer: #821 - Layer info modal: #849 - Update data layer card: #851 - Hidden layers: #867 - Fast follow-ups: #851 , #862, #863, #860 - PR template: #880 ## 🐛 Fixes - Return datasets even when there is a dataset without summaries: #786 - Show all the datasets on Data Catalog page: #837 - Block Map user defined position fix: #784 - Geocoder centering on various projecctions: #826 - Wording, typo: #869 #854, #874, - Fix yaxis labeling: #883
hanbyul-here
added a commit
that referenced
this pull request
May 1, 2024
## 🎉 Features - Zoom in AOI, TOI when analysis is run in #906 - Add custom javascript injection #846 - ADR for V2 Refactor: #875 - Open all external links in a new tab in #870 - Include dataset id to filter layers in #910 - Some datasets can only be analyzed with layers from the same source in #913 - Create minimal partial data layer scaffold starting off with Data Catalog for VEDA2 Refactor in #893 - Add analysis preset in #921 ## 🚀 Improvements - Chart style improvement in #903 - Data Catalog enhancement with floating filter sidebar in #918 - Sum as statistics option in #925 - ## 🐛 Fixes - Sort featured stories based on publication date in descending order in #907 - Replace latency with temporalResolution in layer info in #898 - Add a workaround for Safari scroll problem in #909 - Handle empty result in #922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to a memo directing agencies to ensure that GSA’s Digital Analytics Program (DAP) tracking code is installed on all public-facing sites to enable reporting of web traffic metrics, we need to add a custom script tag to the header. This PR allows us to do so by defining two environment variables in the .env file:
CUSTOM_SCRIPT_SRC=<DAP_SRC>
CUSTOM_SCRIPT_ID=<DAP_ID>
Also allows other users to include a custom analytics script.