Manually center geocoding result #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
force-pushed
the
813-bump-mapbox
branch
from
c5381a4 to
db5f6b6
Compare
hanbyul-here
force-pushed
the
813-bump-mapbox
branch
from
5cfa0ea to
c0a9486
Compare
j08lue
approved these changes
Feb 7, 2024
1 task
sandrahoang686
added a commit
that referenced
this pull request
Feb 13, 2024
https://github.com/NASA-IMPACT/veda-ui/releases/tag/v4.1.0 ## 🎉 Features - Experimental CMR Layer: #805 ## 🚀 Improvements - Style - Documentation - Rename critical error page: #806 - Add back button on Exploration page: #779 - Add ts, lint check for precommit hooks: #788, #809 - "skip to main" button for navigation: #808 ## 🐛 Fixes - Return datasets even when there is a dataset without summaries: #786 - Show all the datasets on Data Catalog page: #837 - Block Map user defined position fix: #784 - Geocoder centering on various projecctions: #826
Merged
hanbyul-here
added a commit
that referenced
this pull request
Mar 25, 2024
## 🎉 Features - Optional media attributes for layers: #843 - Add custom javascript injection #846 - ADR for V2 Refactor: #875 ## 🚀 Improvements - E&A imporvement. Related tickets - Layer select modal: #845 - Connect dataset information on layer: #821 - Layer info modal: #849 - Update data layer card: #851 - Hidden layers: #867 - Fast follow-ups: #851 , #862, #863, #860 - PR template: #880 ## 🐛 Fixes - Return datasets even when there is a dataset without summaries: #786 - Show all the datasets on Data Catalog page: #837 - Block Map user defined position fix: #784 - Geocoder centering on various projecctions: #826 - Wording, typo: #869 #854, #874, - Fix yaxis labeling: #883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #813
It seems to be a known bug : mapbox/mapbox-gl-js#12565
I put a manual workaround to center the map with the result from the geocoder for now. But hopefully, we can get rid of this workaround soon with Mapbox resolving the issue.
(Sorry for confusing branch name, I thought bumping Mapbox would resolve the issue at first, but it seems not all the fixes have made it to production yet.)