Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmr layer #805

Merged
merged 11 commits into from
Jan 25, 2024
Merged

Cmr layer #805

merged 11 commits into from
Jan 25, 2024

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Jan 18, 2024

  • I ended up leaving the main logic as it is (CMR layer doesn't call CMR endpoint directly - There seem to be some cases that stac collection id doesn't match with cmr's short_name? ex. https://cmr.earthdata.nasa.gov/search/collections.umm_json?short_name=TRMM_3B42_Daily.v7&version=07 - I get an empty response _ all in all, I thought it is better to keep the source of truth in one place for now.)

  • Make CMR layer (that shares zarr paint layer with Zarr layer)

  • We currently have two map components (which we should consolidate in the near future related issue: Replace duplicated map component #712 ) This is why there are two places for the layers.

  • CMR layer won't show up for Analysis. (The timeline will fail for new E&A. User can still explore the map.- you can check
    new E&A page by putting a feature flagging variable in .env: FEATURE_NEW_EXPLORATION = 'TRUE'. I also attached a screenshot below.)

Screen Shot 2024-01-19 at 9 27 09 AM

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 76d9214
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/65a97ee909db0e00087a56b0
😎 Deploy Preview https://deploy-preview-805--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanbyul-here hanbyul-here changed the title Cmr layer sketch Cmr layer Jan 18, 2024
@hanbyul-here hanbyul-here mentioned this pull request Jan 18, 2024
Copy link
Contributor

@abarciauskas-bgse abarciauskas-bgse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hanbyul-here ! It looks good to me. I have 2 questions which are non-blocking:

  1. can you remind me the purpose of style-generators?
  2. There is a lot of similar code in https://github.com/NASA-IMPACT/veda-ui/blob/cmr-layer-sketch/app/scripts/components/common/map/style-generators/zarr-timeseries.tsx and https://github.com/NASA-IMPACT/veda-ui/blob/cmr-layer-sketch/app/scripts/components/common/mapbox/layers/zarr-timeseries.tsx. Would it be possible to create more shared components or functions or definitions across these 2 directories?

@hanbyul-here
Copy link
Collaborator Author

  1. style-generator styles for Mapbox, that eventually gets passed into mapinstance to update styles for new parameters etc.
  2. Yes, they are very similar to each other. It is a part of tech debt that we have to solve sooner, even though it will be more like getting rid of https://github.com/NASA-IMPACT/veda-ui/blob/cmr-layer-sketch/app/scripts/components/common/mapbox/layers/zarr-timeseries.tsx. Related issue: Cmr layer  #805 the code in mapbox is OG one, used when only one layer is allowed. As new A&E page requires multiple layers, we moved to the new one in map. So the new A&E page uses map, while the current explore (and mdx maps) uses Mapbox..
    We are putting more effort towards making everything use the new way of using maps, rather than doing something with the old way of using maps. (because they don't need to exist together.)

@abarciauskas-bgse
Copy link
Contributor

@hanbyul-here Thanks for the explanation! I still don't fully understand "style-generator styles for Mapbox, that eventually gets passed into mapinstance to update styles for new parameters etc." but that explanation is good for now and if I need to understand it in the future I will dig in more.

@hanbyul-here hanbyul-here merged commit 21db1bd into main Jan 25, 2024
8 checks passed
@hanbyul-here hanbyul-here deleted the cmr-layer-sketch branch January 25, 2024 15:46
sandrahoang686 added a commit that referenced this pull request Feb 13, 2024
https://github.com/NASA-IMPACT/veda-ui/releases/tag/v4.1.0

## 🎉 Features
- Experimental CMR Layer:
#805

## 🚀 Improvements
- Style 
- Documentation
- Rename critical error page:
#806
- Add back button on Exploration page:
#779
- Add ts, lint check for precommit hooks:
#788,
#809
- "skip to main" button for navigation:
#808

## 🐛 Fixes
- Return datasets even when there is a dataset without summaries:
#786
- Show all the datasets on Data Catalog page:
#837
- Block Map user defined position fix:
#784
- Geocoder centering on various projecctions:
#826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants