-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmr layer #805
Cmr layer #805
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hanbyul-here ! It looks good to me. I have 2 questions which are non-blocking:
- can you remind me the purpose of style-generators?
- There is a lot of similar code in https://github.com/NASA-IMPACT/veda-ui/blob/cmr-layer-sketch/app/scripts/components/common/map/style-generators/zarr-timeseries.tsx and https://github.com/NASA-IMPACT/veda-ui/blob/cmr-layer-sketch/app/scripts/components/common/mapbox/layers/zarr-timeseries.tsx. Would it be possible to create more shared components or functions or definitions across these 2 directories?
|
@hanbyul-here Thanks for the explanation! I still don't fully understand "style-generator styles for Mapbox, that eventually gets passed into mapinstance to update styles for new parameters etc." but that explanation is good for now and if I need to understand it in the future I will dig in more. |
https://github.com/NASA-IMPACT/veda-ui/releases/tag/v4.1.0 ## 🎉 Features - Experimental CMR Layer: #805 ## 🚀 Improvements - Style - Documentation - Rename critical error page: #806 - Add back button on Exploration page: #779 - Add ts, lint check for precommit hooks: #788, #809 - "skip to main" button for navigation: #808 ## 🐛 Fixes - Return datasets even when there is a dataset without summaries: #786 - Show all the datasets on Data Catalog page: #837 - Block Map user defined position fix: #784 - Geocoder centering on various projecctions: #826
I ended up leaving the main logic as it is (CMR layer doesn't call CMR endpoint directly - There seem to be some cases that stac collection id doesn't match with cmr's short_name? ex. https://cmr.earthdata.nasa.gov/search/collections.umm_json?short_name=TRMM_3B42_Daily.v7&version=07 - I get an empty response _ all in all, I thought it is better to keep the source of truth in one place for now.)
Make CMR layer (that shares zarr paint layer with Zarr layer)
We currently have two map components (which we should consolidate in the near future related issue: Replace duplicated map component #712 ) This is why there are two places for the layers.
CMR layer won't show up for Analysis. (The timeline will fail for new E&A. User can still explore the map.- you can check
new E&A page by putting a feature flagging variable in
.env
:FEATURE_NEW_EXPLORATION = 'TRUE'
. I also attached a screenshot below.)