Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retirement checking not functioning as intended due to Campaign Operations rating system #3817

Closed
SuperStucco opened this issue Jan 20, 2024 · 0 comments · Fixed by #3921 or #3933
Closed

Retirement checking not functioning as intended due to Campaign Operations rating system #3817

SuperStucco opened this issue Jan 20, 2024 · 0 comments · Fixed by #3921 or #3933

Comments

@SuperStucco
Copy link

As with ship searches (#3753) and contract type generation (#3729), retirement checks are using the campaign rating as a modifier for the target number. When this is Campaign Operations the rating number is uncapped, so long term campaigns can get extremely large values compared to the limited level choices in the older Field Manual method.

This is currently in 49.12 but checking the current code base as of 49.17 the same problem will still be present.
IllianiCBT added a commit to IllianiCBT/mekhq that referenced this issue Mar 26, 2024
@IllianiCBT
Closes MegaMek#3817
5e08a95
@IllianiCBT IllianiCBT mentioned this issue Mar 27, 2024
Closed
IllianiCBT added a commit to IllianiCBT/mekhq that referenced this issue Mar 27, 2024
@IllianiCBT
Closes MegaMek#3817
ad7cacd
@IllianiCBT IllianiCBT mentioned this issue Mar 27, 2024
Closed
IllianiCBT added a commit to IllianiCBT/mekhq that referenced this issue Mar 28, 2024
@IllianiCBT
Closes MegaMek#3817
4b67ffa
This was referenced Mar 28, 2024
Merged
Merged
HammerGS added a commit that referenced this issue Apr 6, 2024
@HammerGS
Merging the following PRs
eaeb54e 
+ PR #3922: Add missing cockpit costs and weights
+ PR #3944: Added Nag Dialog for Pregnant Combatants
+ Fix #3943: Unmaintained Unit Nag Dialog Suppressed for Units set to
Salvage
+ PR #3933: Fixes for #3729,#3817,#3753: Clamped Unit Rating Mod for
CamOps (redux)
+ PR #3923: Hide Toughness When 0
+ PR #3915: Added Dialog to Confirm New Campaign (redux)
+ PR #3908: Adjusted Default Tech Counts
+ PR #3967: Adjusted Zoom Speed on Interstellar Map Panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@SuperStucco