Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted Default Tech Counts #3908

Conversation

IllianiCBT
Copy link
Collaborator

Original Behavior

Currently, the Company Generator defaults to the following tech personnel:

Mech Tech: 5
Mechanic: 1
Aerospace Tech: 1
Battle Armor Tech: 0

Problem

This suggests that the default recommended Techs for a starting company are 5 Mech Techs, a Mechanic, and an Aerospace Tech. The majority of our players do not use vehicles or aerospace out of the gate, and those who do are very capable of changing their starting Techs.

More importantly, 5 Mech Techs are not enough to maintain a 12 mech company, which only penalizes inexperienced players who do not know better.

Solution

I have adjusted the default techs as follows:

Mech Tech: 7 (+2)
Mechanic: 0 (-1)
Aerospace Tech: 0 (-1)
Battle Armor Tech: 0

This better fits the needs of the largest portion of our player base and means inexperienced players will enter play with enough Mech Techs to maintain their entire company.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 10.60%. Comparing base (c1e157d) to head (b93037e).
Report is 11 commits behind head on master.

Files Patch % Lines
...se/companyGeneration/CompanyGenerationOptions.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3908   +/-   ##
=========================================
  Coverage     10.60%   10.60%           
  Complexity     5487     5487           
=========================================
  Files           836      836           
  Lines        114267   114266    -1     
  Branches      17184    17182    -2     
=========================================
  Hits          12121    12121           
+ Misses       100936   100935    -1     
  Partials       1210     1210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT changed the title [Company Generator] Adjusted Default Tech Counts Adjusted Default Tech Counts Mar 29, 2024
@IllianiCBT IllianiCBT self-assigned this Mar 29, 2024
@IllianiCBT IllianiCBT added Personnel Personnel-related Issues UX User experience labels Mar 29, 2024
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@HammerGS HammerGS merged commit 67c1841 into MegaMek:master Apr 6, 2024
5 of 6 checks passed
HammerGS added a commit that referenced this pull request Apr 6, 2024
+ PR #3922: Add missing cockpit costs and weights
+ PR #3944: Added Nag Dialog for Pregnant Combatants
+ Fix #3943: Unmaintained Unit Nag Dialog Suppressed for Units set to
Salvage
+ PR #3933: Fixes for #3729,#3817,#3753: Clamped Unit Rating Mod for
CamOps (redux)
+ PR #3923: Hide Toughness When 0
+ PR #3915: Added Dialog to Confirm New Campaign (redux)
+ PR #3908: Adjusted Default Tech Counts
+ PR #3967: Adjusted Zoom Speed on Interstellar Map Panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants