Added Dialog to Confirm New Campaign (redux) #3915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3915 +/- ##
============================================
+ Coverage 10.60% 10.65% +0.04%
- Complexity 5487 5536 +49
============================================
Files 836 840 +4
Lines 114266 114376 +110
Branches 17182 17202 +20
============================================
+ Hits 12121 12189 +68
- Misses 100935 100957 +22
- Partials 1210 1230 +20 ☔ View full report in Codecov by Sentry. |
IllianiCBT
changed the title
NickAragua
reviewed
Apr 4, 2024
Co-authored-by: NickAragua <[email protected]>
HammerGS
added a commit
that referenced
this pull request
Apr 6, 2024
+ PR #3922: Add missing cockpit costs and weights + PR #3944: Added Nag Dialog for Pregnant Combatants + Fix #3943: Unmaintained Unit Nag Dialog Suppressed for Units set to Salvage + PR #3933: Fixes for #3729,#3817,#3753: Clamped Unit Rating Mod for CamOps (redux) + PR #3923: Hide Toughness When 0 + PR #3915: Added Dialog to Confirm New Campaign (redux) + PR #3908: Adjusted Default Tech Counts + PR #3967: Adjusted Zoom Speed on Interstellar Map Panel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redux of #3909 which was closed due to an unusually high volume of dirty edits.
Current Implementation
Currently the option to start a new campaign is available through 'toolbar/files/new campaign' and is listed immediately beneath Save Campaign and Load Campaign.
Problem
I am aware of a long standing bug where clicking 'new campaign' and then cancelling out can have adverse effects on a campaigns' 'campaign settings'. The proximity of the option near 'save' and 'load' increases the chances of a user accidentally interacting with 'new campaign'. In these events, the user will naturally cancel out of the option and (unless they're on Discord a lot) they will likely be unaware of the damage this potentially caused.
Solution
This has been a problem for years at this point, while the issue being fully resolved is the more desirable outcome, this patch is designed to reduce the chance of users accidentally clicking 'new campaign' when attempting to save or load.
Update
Since the initial introduction of this PR I have significantly changed its implementation.
When selecting 'New Campaign' users will be presented with a dialog asking them to confirm that they wish to start a new campaign. Selecting 'no' or closing the dialog does nothing. Selecting 'yes' initiates the new campaign process (this process is identical to current implementation).