Activate miq_task when deliver from miq_queue #17015

yrudman · 2018-02-16T20:54:14Z

This PR:

ensure that any task will have corect started date
if arguments for queued method is Hash than :miq_task_id => <task id> will be added to parameters when delivering

blocked by:

Add miq_task_id column to miq_queue table manageiq-schema#167 - Add miq_task_id column to miq_queue table

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1543289

yrudman · 2018-02-19T15:12:14Z

\cc @mkanoor

yrudman · 2018-02-19T15:44:54Z

\cc @Fryguy

yrudman · 2018-03-14T14:13:22Z

@miq-bot assign @Fryguy

Fryguy · 2018-03-14T18:56:22Z

app/models/miq_queue.rb

@@ -541,6 +543,13 @@ def self.get_worker(task_id)

  private

+  def activate_miq_task(args)
+    MiqTask.update_status(miq_task_id, MiqTask::STATE_ACTIVE,  MiqTask::STATUS_OK, "Task starting") if miq_task


Prefer if miq_task_id, so it doesn't need to go out and fetch the task on every dispatch. That being said, if the task is deleted out from underneath the queue item, the MiqTask.update_status method should probably handle that.

👍 using miq_task_id is better
When task does not exist MiqTask.update_status does handle it it:

manageiq/app/models/miq_task.rb

Line 91 in c76b358

task.update_status(state, status, message) unless task.nil?

Fryguy · 2018-03-14T18:58:37Z

app/models/miq_queue.rb

@@ -541,6 +543,13 @@ def self.get_worker(task_id)

  private

+  def activate_miq_task(args)
+    MiqTask.update_status(miq_task_id, MiqTask::STATE_ACTIVE,  MiqTask::STATUS_OK, "Task starting") if miq_task
+    pars = args.first


Prefer params or parameters...pars is not a common abbreviation, so it reads funny.

Fryguy · 2018-03-14T19:02:58Z

@yrudman What happens to

existing messages on the queue where the task id is positional
existing usage of the tasks where they don't go through generic_action_with_callback

Fryguy · 2018-03-14T19:22:20Z

app/models/miq_queue.rb

+  def activate_miq_task(args)
+    MiqTask.update_status(miq_task_id, MiqTask::STATE_ACTIVE, MiqTask::STATUS_OK, "Task starting") if miq_task_id
+    params = args.first
+    params[:miq_task_id] = miq_task_id if pars.kind_of?(Hash)


woops (if pars)

yrudman · 2018-03-15T12:44:19Z

@Fryguy

for existing messages in the queue task's update_status will be skipped and :miq_task_id => nil will be added to the parameter Hash when delivering message.
this PR changing task's status before delivering and all task's specific logic happened after that. If tasks already setting active status and dealing with task's id than that code will still be executed correctly.
Examples of dealing with tasks in reporting:
when queueing,
here:

manageiq/app/models/miq_report/generator.rb

Line 172 in fbdd937

:args => [task.id, options],

and here:

manageiq/app/models/miq_report/generator/async.rb

Line 13 in fbdd937

:args => [task.id, options],

when delivered:

manageiq/app/models/miq_report/generator/async.rb

Line 23 in fbdd937

def _async_generate_tables(taskid, options = {})

yrudman · 2018-03-15T14:29:30Z

also, if there is no willingness to use generic_action_with_callback (as in above examples) than adding :miq_task_id to parameters hash for MiqQueue.put will also trigger activating task when delivering.

…o be saved as attribute of queued item

…bute of queued item

… deliver

…linked to queue item

…here is extra parameter added to the hash when message delivered - miq_task_id

miq-bot · 2018-03-16T17:37:13Z

Checked commits yrudman/manageiq@5c32ee4~...f7653b0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 1 offense detected

app/models/miq_task.rb

❗ - Line 24, Col 3 - Rails/HasManyOrHasOneDependent - Specify a :dependent option.

yrudman · 2018-03-16T18:43:39Z

@miq-bot add-label gaprindashvili/no

miq-bot added the wip label Feb 16, 2018

yrudman force-pushed the activate-task-when-deliver-from-queue branch from 11f10b2 to b2a1df7 Compare February 19, 2018 12:33

yrudman mentioned this pull request Mar 13, 2018

Add miq_task_id column to miq_queue table ManageIQ/manageiq-schema#167

Merged

yrudman changed the title ~~[WIP] Activate miq_task when deliver from miq_queue~~ Activate miq_task when deliver from miq_queue Mar 14, 2018

miq-bot assigned Fryguy Mar 14, 2018

miq-bot removed the wip label Mar 14, 2018

Fryguy reviewed Mar 14, 2018

View reviewed changes

yrudman force-pushed the activate-task-when-deliver-from-queue branch 2 times, most recently from 72a1b2d to 31b3663 Compare March 14, 2018 19:54

yrudman mentioned this pull request Mar 15, 2018

Link miq_task and miq_queue tables #17006

Closed

1 task

Fryguy closed this Mar 15, 2018

Fryguy reopened this Mar 15, 2018

yrudman added 7 commits March 16, 2018 13:33

miq_task: added associattion with miq_queue and passeed miq_task_id t…

5c32ee4

…o be saved as attribute of queued item

testing that .generic_action_with_callback store miq_task_id as attri…

5c071f2

…bute of queued item

miq_queue: link to miq_task and added miq_task_id to debugging output

88adbec

adjust miq_queue_spec after adding miq_task_id to debugging output

3338044

if there is task linked to queue item than make this task ACTIVE when…

e4307b7

… deliver

use 'miq_task_id' instead of miq_task when checking if there is task …

079d10c

…linked to queue item

changed log_file_spec: after linking miq_tasks and miq_queue tables t…

f7653b0

…here is extra parameter added to the hash when message delivered - miq_task_id

yrudman force-pushed the activate-task-when-deliver-from-queue branch from dad3655 to f7653b0 Compare March 16, 2018 17:33

Fryguy merged commit 2ead6ad into ManageIQ:master Mar 16, 2018

Fryguy added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 16, 2018

Fryguy added the enhancement label Mar 16, 2018

miq-bot added the gaprindashvili/no label Mar 16, 2018

yrudman deleted the activate-task-when-deliver-from-queue branch March 16, 2018 18:44

yrudman mentioned this pull request Mar 29, 2018

Initialize MiqQueue.miq_task_id column when queuing ems-refresh task #17233

Merged

yrudman mentioned this pull request Apr 13, 2018

Initialize MiqQueue.miq_task_id column when queuing metric capture task #17301

Merged

jameswnl mentioned this pull request Jul 9, 2018

tower_api.update_in_provider to remove miq_task_id from params ManageIQ/manageiq-providers-ansible_tower#106

Merged

mansam mentioned this pull request Oct 16, 2018

Add filtering of image attributes ManageIQ/manageiq-providers-openstack#348

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Activate miq_task when deliver from miq_queue #17015

Activate miq_task when deliver from miq_queue #17015

yrudman commented Feb 16, 2018 •

edited

Loading

yrudman commented Feb 19, 2018

yrudman commented Feb 19, 2018

yrudman commented Mar 14, 2018

Fryguy Mar 14, 2018

yrudman Mar 14, 2018 •

edited

Loading

Fryguy Mar 14, 2018

yrudman Mar 14, 2018

Fryguy commented Mar 14, 2018

Fryguy Mar 14, 2018

yrudman Mar 14, 2018

yrudman commented Mar 15, 2018 •

edited

Loading

yrudman commented Mar 15, 2018 •

edited

Loading

miq-bot commented Mar 16, 2018

yrudman commented Mar 16, 2018

Activate miq_task when deliver from miq_queue #17015

Activate miq_task when deliver from miq_queue #17015

Conversation

yrudman commented Feb 16, 2018 • edited Loading

yrudman commented Feb 19, 2018

yrudman commented Feb 19, 2018

yrudman commented Mar 14, 2018

Fryguy Mar 14, 2018

Choose a reason for hiding this comment

yrudman Mar 14, 2018 • edited Loading

Choose a reason for hiding this comment

Fryguy Mar 14, 2018

Choose a reason for hiding this comment

yrudman Mar 14, 2018

Choose a reason for hiding this comment

Fryguy commented Mar 14, 2018

Fryguy Mar 14, 2018

Choose a reason for hiding this comment

yrudman Mar 14, 2018

Choose a reason for hiding this comment

yrudman commented Mar 15, 2018 • edited Loading

yrudman commented Mar 15, 2018 • edited Loading

miq-bot commented Mar 16, 2018

yrudman commented Mar 16, 2018

yrudman commented Feb 16, 2018 •

edited

Loading

yrudman Mar 14, 2018 •

edited

Loading

yrudman commented Mar 15, 2018 •

edited

Loading

yrudman commented Mar 15, 2018 •

edited

Loading