Initialize MiqQueue.miq_task_id column when queuing metric capture task #17301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
link-task-and-queued-metric-capture-command
branch
2 times, most recently
from
82f0cdc to
5421247
Compare
yrudman
changed the title
agrare
reviewed
Apr 18, 2018
| @@ -110,6 +110,9 @@ def perf_capture_queue(interval_name, options = {}) | |||
| nil | |||
| end | |||
| end | |||
| # main reason for setting miq_task_id is to initializes MiqTask.started_on column when message delivered. | |||
| # there is no harm to update miq_task_id twice (if job is still running) | |||
| queued_item.update_attributes(:miq_task_id => task_id) if task_id | |||
There was a problem hiding this comment.
@yrudman can you set the task_id in block instead? Since put_or_update already does create or update_attributes.
yrudman
force-pushed
the
link-task-and-queued-metric-capture-command
branch
from
c44ea86 to
374a2e5
Compare
agrare
reviewed
Apr 18, 2018
| @@ -355,6 +355,13 @@ def verify_perf_capture_queue(last_perf_capture_on, total_queue_items) | |||
| verify_perf_capture_queue(last_perf_capture_on, 11) | |||
| end | |||
| end | |||
|
|
|||
| it "links supplied miq_task with queued item which allow to initialize MiqTask#started_on attribute" do | |||
| MiqQueue.delete_all | |||
There was a problem hiding this comment.
This is weird, I see it is this way in the rest of these tests so I won't hold this up. IMO these should be in different contexts so we don't have to clear database records.
There was a problem hiding this comment.
yes, agreed, it does look strange
…erride existing value if second task created for the already queued request. Having MiqQueue#miq_task_id column initialized will allow automaticly populate MiqTask_started_on when queed metric capture command delivered. It become possible after merginghttps://github.com/ManageIQ/pull/17015. related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1543289
yrudman
force-pushed
the
link-task-and-queued-metric-capture-command
branch
from
374a2e5 to
8bd560b
Compare
|
Checked commits yrudman/manageiq@0861aee~...8bd560b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow to automatically initialize
MiqTask.started_onfield when queued command to perform metric capture delivered.This PR is follow-up to #17015
related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1543289
@miq-bot add-label core, enhancement