Add filtering of image attributes

[andyvesel]

Added filtering in options from unnecessary data, which doesn't belong to image attributes

[andyvesel]

@aufi could you review?

[aufi]

This seems to fix issue with miq_queue keys in attributes, but to have it fully correct, it is needed check attributes against Fog Image instead of MIQ Template.

self.attributes are attributes of Template class, service.images.find_by_id(ems_ref) returns Fog object - https://github.com/fog/fog-openstack/blob/master/lib/fog/image/openstack/v2/models/image.rb its attributes should be checked.

[andyvesel]

Updated PR

[alexander-demicev]

Should this filtering also be added to create action?

[miq-bot]

Checked commits andyvesel/manageiq-providers-openstack@5583530~...1b7fc7f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

app/models/manageiq/providers/openstack/cloud_manager/template.rb

• ❗ - Line 102, Col 21 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id.

[mansam]

Looks fine, but why are invalid parameters making it into the update call in the first place?

[andyvesel]

Looks fine, but why are invalid parameters making it into the update call in the first place?

@mansam, For some reason in options hash we getting unneeded parameters like miq_task and miq_task_id. (i.e. {"id" => "37", "name" => "foo", :miq_task => 1800, :miq_task_id => 1200})
Fog Image have no attributes like miq_task and miq_task_id, so I intended to keep in options only those attributs, which are belong to image.
We've no BZ for this. It's a kind of workaround, but with this "filtering" updating of images works correctly

[mansam]

@andyvesel Alright, thanks for the explanation. This workaround is fine, but we should discover why these incorrect parameters are reaching this method.

[andyvesel]

@andyvesel Alright, thanks for the explanation. This workaround is fine, but we should discover why these incorrect parameters are reaching this method.

Agree with that, I'll figure this out

[mansam]

@andyvesel It looks like those extra parameters are inserted by the MiqTask and MiqQueue classes for some reason.

ManageIQ/manageiq#17015
https://github.com/ManageIQ/manageiq/blob/master/app/models/miq_queue.rb#L557
https://github.com/ManageIQ/manageiq/blob/master/app/models/miq_task.rb#L292