Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize MiqQueue.miq_task_id column when queuing ems-refresh task #17233

Merged
merged 2 commits into from
Apr 12, 2018

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Mar 29, 2018

This PR will allow to automatically initialize MiqTask.started_on field when ems_refresh queued command delivered.

This PR is follow-up to #17015

@miq-bot add-label core, technical debt

…ask.started_on field will be initialized automaticly when message delivered. It become possible after merginghttps://github.com/ManageIQ/pull/17015
@yrudman yrudman force-pushed the link-task-and-ems-refres-queue-item branch from 1dfb792 to 30586c4 Compare April 11, 2018 21:38
@yrudman yrudman force-pushed the link-task-and-ems-refres-queue-item branch from 30586c4 to 5d22866 Compare April 11, 2018 21:58
@yrudman yrudman changed the title [WIP] Initialize MiqQueue.miq_task_id column when queuing ems-refresh task Initialize MiqQueue.miq_task_id column when queuing ems-refresh task Apr 11, 2018
@yrudman
Copy link
Contributor Author

yrudman commented Apr 11, 2018

@agrare could you take a look at this PR

@miq-bot
Copy link
Member

miq-bot commented Apr 11, 2018

Checked commits yrudman/manageiq@9422796~...5d22866 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@miq-bot miq-bot removed the wip label Apr 11, 2018
@agrare agrare self-assigned this Apr 12, 2018
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrare agrare merged commit 0086f71 into ManageIQ:master Apr 12, 2018
@yrudman yrudman deleted the link-task-and-ems-refres-queue-item branch April 12, 2018 13:48
@agrare agrare added this to the Sprint 84 Ending Apr 23, 2018 milestone Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants