Toolbars - use send_checked, refactor params in miqToolbarOnClick

[himdel]

Depends on ManageIQ/ui-components#185

Fixes #588 (except for cleanup)

• makes send_checked propagate from toolbar definitions to the toolbar component
• makes custom buttons send send_checked: true whenever id=LIST
• refactors miqToolbarOnClick and changes to use send_checked instead of url_params when determining when to send miq_grid_checks:

miqToolbarOnClick differences

• we no longer use url_parms to know when to send miq_grid_checks

  • before: when ending with _div and nonempty, or containing id=LIST
  • now: when send_checked and nonempty
  • change: params[:miq_grid_checks] will be nil instead of "" when nothing is selected even for custom buttons

• we always call miqSerializeForm when ending with _div, but clean up nothings

  • before: when _div and (gridChecks) empty
  • now: always, but returns "" for GTLs
  • (but the alternative of sending when _div and not send_checked or empty is probably wrong anyway)

• the ? url_params variant is handled a bit differently

  • ? position
    • before: this would affect any url_parms containing a question mark
    • now: url_parms needs to start with it
    • but not seeing any url_parms values where this would matter
  • multiple ?
    • before: split[1] pretty much means just anything between the first two question marks
    • now: slice(1) will use the whole string
    • but not seeing any url_parms values where this would matter

Cc @martinpovolny

[martinpovolny]

Travis restarted.

[himdel]

Fixed specs (and a bug in JS when url_parms was undefined) :)

[martinpovolny]

@himdel: all the CC issues are easily fixable ;-)

[himdel]

@martinpovolny Yes but do we actually want them fixed?

Identifier 'url_parms' is not in camel case. - easy fix, but then searching for url_parms won't find the code. (In general I'm starting to think the camelCase rule doesn't make sense for any code interacting with the ruby bits.)

'params' is already declared in the upper scope. - sure it is. Which made me check that this is really supposed to be a different params, it is, mission accomplished :). I can of course rename the new one to outputParams or whatever, but.. is there any point? :)

WDYT? :)
I'll of course fix both if you want me to, just saying, both are marked as warnings and that's on purpose.
If we really want to start enforcing rules 100% time, we need to drop a few.

(That said, 6d6755f should fix those warnings.)

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[martinpovolny]

'params' is already declared in the upper scope. - sure it is. Which made me check that this is really supposed to be a different params, it is, mission accomplished :). I can of course rename the new one to outputParams or whatever, but.. is there any point? :)

Please, fix this one. It's a readability issue.

Also you are setting the standards here. So please, set it high ;-)

[miq-bot]

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/4a6aee37f8c343147eb26c66671c309fa1594db8~...b7f8ff4a3994147c96baa98a0c5b9e3defe17d39 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[himdel]

Ok, ok, updated to address CC warnings .. aand rebased :).