Display custom buttons after comming from relationship table

[romanblanco]

The code displays the custom buttons if the previous screen was a
provider screen (@record) and displayed item (@display) is from the list
of classes supported by custom buttons (APPLIES_TO_CLASS_BASE_MODELS)

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1635738

Links

• https://bugzilla.redhat.com/show_bug.cgi?id=1635738
• [WIP][GAPRINDASHVILI] Display custom buttons after coming from relationship table #4772

Steps for Testing/QA

• Create a custom button for any entity
• Navigate to the entity through the provider relationship screen
• Custom button should be visible

[himdel]

you can remove MiqTemp, no such thing

[romanblanco]

@miq-bot add_label blocker
@miq-bot add_label bug
@miq-bot add_label button
@miq-bot add_label actions toolbars
@miq-bot add_label hammer/yes

[miq-bot]

@romanblanco Cannot apply the following label because they are not recognized: button

[miq-bot]

@romanblanco Cannot apply the following label because they are not recognized: actions toolbars

[himdel]

(Script to add custom buttons: https://github.com/himdel/dotfiles/blob/master/ManageIQ/custom_button.rb (thanks to @ZitaNemeckova))

[h-kataria]

@romanblanco will this PR also show custom buttons when viewing list of Hosts for a Cluster or a Storage?

[ZitaNemeckova]

It's possible to execute custom button without anything selected from nested list view. Not consistent with list view.

From list view:

From nested list:

And it uses the id of the parent(Provider) instead of the id of selected item. When parent and child class don't have an instance with same id it throws an error:

Cloud Provider -> Cloud Tenants -> check one or more Cloud Tenants-> click custom button for list -> button uses id of Provider instead of Cloud Tenants

Container Provider -> Container Nodes -> check one or more Container Nodes-> click custom button for list -> button uses id of Provider instead of Container Nodes

[ZitaNemeckova]

Just a check that Custom button is in toolbar in nested view for list and single entity:

• Availability Zone
• Cloud Tenant
• Orchestration Stack
• Security Group
• Tenant - error on click
• Cluster / Deployment Role
• Host / Node
• Datastore
• VM Template and Image for Infra Provider
• VM and Instance for Infra Provider
• Container Project
• Container Pod
• Container Node
• Container Template
• Container Image

Missing custom button for nested list:

• Provider - Cloud Provider summary page -> Storage Managers
• Cloud Volume
• VM Template and Image for Cloud Provider
• VM and Instance for Cloud Provider
• Cloud Object Store Container
• Cloud Network
• Load Balancer
• Network Router
• Container Volume
• Cloud Subnet

[JPrause]

@romanblanco if this will be able to be backported, can you also add the gaprindashvili/yes

[romanblanco]

@miq-bot add_label hammer/yes
@miq-bot add_label gaprindashvili/yes

Closing #4772

[mzazrivec]

@ZitaNemeckova @himdel are the current changes OK with you?

[mzazrivec]

@romanblanco the CI failures seem related.

[miq-bot]

Checked commits romanblanco/manageiq-ui-classic@828a7de~...1623721 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
11 files checked, 0 offenses detected
Everything looks fine. 🍰

[JPrause]

@romanblanco where does this PR stand.

[romanblanco]

@JPrause I don't plan to do any more changes.

[himdel]

Not seeing any breakage, LGTM :)

[simaishi]

Hammer backport details:

$ git log -1
commit 19322dadedf1a99acf922c9e6de9e1674519ca67
Author: Martin Hradil <[email protected]>
Date:   Tue Oct 30 14:31:25 2018 +0100

    Merge pull request #4775 from romanblanco/bz1635738-master
    
    Display custom buttons after comming from relationship table
    
    (cherry picked from commit 98b7dd0e893120c7d40391644306c35304137d60)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635738

[simaishi]

@romanblanco Not sure how to resolve this conflict...

--- a/app/helpers/application_helper/toolbar_builder.rb
+++ b/app/helpers/application_helper/toolbar_builder.rb
@@@ -274,6 -234,11 +275,14 @@@ class ApplicationHelper::ToolbarBuilde
      }
      button[:text] = button_name if input[:text_display]
      button[:onwhen] = '1+' if cb_enabled_for_nested
++<<<<<<< HEAD
++=======
+     if record_id == 'LIST' ||
+        (@display.present? &&
+         custom_button_appliable_class?(@display.camelize.singularize))
+       button[:send_checked] = true
+     end
++>>>>>>> 98b7dd0e8... Merge pull request #4775 from romanblanco/bz1635738-master
      button
    end

button[:send_checked] = true if record_id == 'LIST' (the line this PR modified to the if above) doesn't exist in Gaprindashvili branch. Does that make this whole if unnecessary for G branch??

[himdel]

That line was introduced in #2398 (gaprindashvili/no), because we simplified the condition of when to send the list of checked items to a simple "is send_checked true?".

So, send_checked will not do anything in gaprindashvili and is therefore not needed, but we do need to make sure the old mechanism kicks in.

The previous logic was essentially "url_parms ends with _div" or "url_parms contains id=LIST".

@romanblanco can you verify that record_id is always LIST in that case? If so, we can just skip that check completely. But if we ever depend on the second condition (id is not LIST but @display.present? && custom_button_appliable_class?(@display.camelize.singularize) is true), we would need to adjust the code accordingly.
(Just note that we can't really rewrite url_parms in that case, so we would need to change miqToolbarOnClick to support that - in which case introducing some level of send_checked support doesn't seem like a bad idea.)

(I'm thinking it should be OK to remove, since you never need to send a list of checked items on a detail screen .. probably.)

[romanblanco]

@himdel the condition is necessary.

The first part of condition (record_id == 'LIST') describes usual GTL list, where we want the custom buttons rendered (Infra -> Hosts)

The second part ((@display.present? && custom_button_appliable_class?(@display.camelize.singularize))) describes a case, when the list is accessed through relationship screen (Infra -> Provider -> Hosts (from relationship screen)), and therefore the record_id is not 'LIST' but an id of the provider

[romanblanco]

@simaishi I've created a new PR that corrects the conflicting logic, taking it back to it's previous form (button[:send_checked] = true if record_id == 'LIST').

#4887

[simaishi]

Backported to Gaprindashvili via #4893