-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missed send_check to cloud network toolbars #3162
Adding missed send_check to cloud network toolbars #3162
Conversation
@miq-bot add_label grapridashvili/yes,bug |
@lpichler Cannot apply the following label because they are not recognized: grapridashvili/yes |
LGTM, this one was missed in #2398 :) Looks like theres 3 more places missing diff --git a/app/helpers/application_helper/toolbar/cloud_networks_center.rb b/app/helpers/application_helper/toolbar/cloud_networks_center.rb
index 12b5ca3680..626bad7394 100644
--- a/app/helpers/application_helper/toolbar/cloud_networks_center.rb
+++ b/app/helpers/application_helper/toolbar/cloud_networks_center.rb
@@ -22,6 +22,7 @@ class ApplicationHelper::Toolbar::CloudNetworksCenter < ApplicationHelper::Toolb
t = N_('Edit selected Cloud Network'),
t,
:url_parms => 'main_div',
+ :send_checked => true,
:enabled => false,
:onwhen => '1'),
button(
@@ -30,6 +31,7 @@ class ApplicationHelper::Toolbar::CloudNetworksCenter < ApplicationHelper::Toolb
t = N_('Delete selected Cloud Networks'),
t,
:url_parms => 'main_div',
+ :send_checked => true,
:confirm => N_('Warning: The selected Cloud Networks and ALL of their components will be removed!'),
:enabled => false,
:onwhen => '1+')
diff --git a/app/helpers/application_helper/toolbar/flavors_center.rb b/app/helpers/application_helper/toolbar/flavors_center.rb
index add8b31ec9..052ea3b882 100644
--- a/app/helpers/application_helper/toolbar/flavors_center.rb
+++ b/app/helpers/application_helper/toolbar/flavors_center.rb
@@ -20,6 +20,7 @@ class ApplicationHelper::Toolbar::FlavorsCenter < ApplicationHelper::Toolbar::Ba
t = N_('Remove selected Flavors'),
t,
:url_parms => "main_div",
+ :send_checked => true,
:confirm => N_("Warning: The selected Flavors will be permanently removed!"),
:enabled => false,
:onwhen => "1+" |
@himdel definitely :) |
ce75589
to
12dbc74
Compare
Done 👍 |
Checked commit lpichler@12dbc74 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
#2398 isn't backported to Gaprindashvili, so I assume this shouldn't be |
Confirmed, #2398 never made it in gaprindashvili .. changing to no, sorry :). |
reproducer:
@miq-bot assign @himdel