Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbars - use send_checked, refactor params in miqToolbarOnClick #2398

Merged
merged 6 commits into from
Nov 14, 2017
+51 −43
Merged

Toolbars - use send_checked, refactor params in miqToolbarOnClick #2398

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4a6aee3
miqToolbarOnClick - extract params handling into a separate function
himdel Oct 13, 2017
6cf594c
ToolbarBuilder#create_custom_button - add send_checked when id=LIST
himdel Oct 13, 2017
2fb4a83
ToolbarBuilder#apply_common_props - propagate send_checked
himdel Oct 13, 2017
df969ee
miqToolbarOnClick>getParams - use send_checked, simplify
himdel Oct 13, 2017
8e26027
ToolbarBuilder spec - add missing send_checked to download_pdf
himdel Nov 2, 2017
b7f8ff4
toolbarOnClick - fix eslint warnings
himdel Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ToolbarBuilder#apply_common_props - propagate send_checked
@himdel
himdel committed Nov 14, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 2fb4a8374c7ff420798afba99018bcd8f65ce681
15 changes: 8 additions & 7 deletions app/helpers/application_helper/toolbar_builder.rb
View file
Original file line number Diff line number Diff line change
@@ -133,13 +133,14 @@ def build_select_button(bgi, index)
# Set properties for button
def apply_common_props(button, input)
button.update(
:icon => input[:icon],
:color => input[:color],
:name => button[:id],
:hidden => button[:hidden] || !!input[:hidden],
:pressed => input[:pressed],
:onwhen => input[:onwhen],
:data => input[:data]
:color => input[:color],
:data => input[:data],
:hidden => button[:hidden] || !!input[:hidden],
:icon => input[:icon],
:name => button[:id],
:onwhen => input[:onwhen],
:pressed => input[:pressed],
:send_checked => input[:send_checked],
)

button[:enabled] = input[:enabled]