Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Toolbar and dialog demo #468

Closed
wants to merge 24 commits into from

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Jul 23, 2018

To be used with ManageIQ/manageiq-ui-classic#4315

Replaces: #460

Includes:

For the backend part by @Ladas to actually work, you need to:

devil - [~]$ pip install --user ansible-runner

So that:

devil - [~]$ ansible-runner --version
1.0.4

@martinpovolny martinpovolny changed the title [WIP] Toolbar demo2 [WIP] Toolbar and dialog demo Jul 23, 2018
@miq-bot miq-bot added the wip label Jul 24, 2018
@miq-bot
Copy link
Member

miq-bot commented Aug 8, 2018

Checked commits martinpovolny/manageiq-providers-amazon@34cfa17~...704d754 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
21 files checked, 35 offenses detected

app/helpers/manageiq/providers/amazon/toolbar_overrides/ems_cloud_center.rb

app/helpers/manageiq/providers/amazon/toolbar_overrides/ems_network_center.rb

  • ❗ - Line 17, Col 74 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 18, Col 11 - Layout/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 7, Col 13 - Layout/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/manageiq/providers/amazon/toolbar_overrides/x_vm_cloud_center.rb

app/models/manageiq/providers/amazon/network_manager/security_group.rb

content_tmp/ansible/create_security_group.yml

  • ⚠️ - Line 7, Col 5 - indentation - wrong indentation: expected 2 but found 4

content_tmp/ansible/roles/change_vm_state/defaults/main.yml

  • 💣 💥 🔥 🚒 - Line 2, Col 36 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/change_vm_state/handlers/main.yml

  • 💣 💥 🔥 🚒 - Line 2, Col 36 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/change_vm_state/meta/main.yml

  • ⚠️ - Line 8, Col 5 - indentation - wrong indentation: expected 2 but found 4

content_tmp/ansible/roles/change_vm_state/tasks/main.yml

  • ⚠️ - Line 7, Col 1 - 1 > 0) (empty-lines - too many blank lines

content_tmp/ansible/roles/change_vm_state/tests/test.yml

  • ⚠️ - Line 7, Col 5 - indentation - wrong indentation: expected 2 but found 4

content_tmp/ansible/roles/change_vm_state/vars/main.yml

  • 💣 💥 🔥 🚒 - Line 2, Col 32 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/create_security_group/defaults/main.yml

  • 💣 💥 🔥 🚒 - Line 2, Col 42 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/create_security_group/handlers/main.yml

  • 💣 💥 🔥 🚒 - Line 2, Col 42 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/create_security_group/meta/main.yml

  • 💣 💥 🔥 🚒 - Line 57, Col 42 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/create_security_group/tests/test.yml

  • ⚠️ - Line 29, Col 1 - 1 > 0) (empty-lines - too many blank lines
  • ⚠️ - Line 7, Col 5 - indentation - wrong indentation: expected 2 but found 4

content_tmp/ansible/roles/create_security_group/vars/main.yml

  • 💣 💥 🔥 🚒 - Line 2, Col 38 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/start_vm.yml

  • ⚠️ - Line 9, Col 5 - indentation - wrong indentation: expected 2 but found 4

content_tmp/ansible/stop_vm.yml

  • ⚠️ - Line 9, Col 5 - indentation - wrong indentation: expected 2 but found 4

@miq-bot
Copy link
Member

miq-bot commented Feb 18, 2019

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants