[DEMO] Add notifications around the toolbar and dialog demo for ansible operations

[skateman]

Demo around @martinpovolny's PR #468 with notifications.

It was necessary to pass ˙user_id˙ as an extra argument for the create_security_group method. The task initiation comes from the API, so the arguments had to be adjusted there in ManageIQ/manageiq-api#450.

The new notification types and the notification mixin comes from ManageIQ/manageiq#17835

[miq-bot]

Checked commits skateman/manageiq-providers-amazon@9ce7e67~...9618637 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
21 files checked, 37 offenses detected

app/helpers/manageiq/providers/amazon/toolbar_overrides/ems_cloud_center.rb

• ❗ - Line 17, Col 74 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 29, Col 74 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 36, Col 46 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 37, Col 46 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 38, Col 46 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 39, Col 46 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 40, Col 46 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 41, Col 46 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 42, Col 46 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 44, Col 25 - Layout/MultilineHashBraceLayout - Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element.
• ❗ - Line 45, Col 74 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 46, Col 11 - Layout/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
• ❗ - Line 7, Col 13 - Layout/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/manageiq/providers/amazon/toolbar_overrides/ems_network_center.rb

• ❗ - Line 17, Col 74 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 18, Col 11 - Layout/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
• ❗ - Line 7, Col 13 - Layout/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/manageiq/providers/amazon/toolbar_overrides/x_vm_cloud_center.rb

• ❗ - Line 34, Col 25 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 38, Col 11 - Layout/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
• ❗ - Line 7, Col 13 - Layout/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/models/manageiq/providers/amazon/network_manager/security_group.rb

• ❗ - Line 12, Col 27 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.
• ❗ - Line 19, Col 27 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.
• ❗ - Line 20, Col 5 - Style/RescueStandardError - Avoid rescuing without specifying an error class.

content_tmp/ansible/create_security_group.yml

• ⚠️ - Line 7, Col 5 - indentation - wrong indentation: expected 2 but found 4

content_tmp/ansible/roles/change_vm_state/defaults/main.yml

• 💣 💥 🔥 🚒 - Line 2, Col 36 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/change_vm_state/handlers/main.yml

• 💣 💥 🔥 🚒 - Line 2, Col 36 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/change_vm_state/meta/main.yml

• ⚠️ - Line 8, Col 5 - indentation - wrong indentation: expected 2 but found 4

content_tmp/ansible/roles/change_vm_state/tasks/main.yml

• ⚠️ - Line 7, Col 1 - 1 > 0) (empty-lines - too many blank lines

content_tmp/ansible/roles/change_vm_state/tests/test.yml

• ⚠️ - Line 7, Col 5 - indentation - wrong indentation: expected 2 but found 4

content_tmp/ansible/roles/change_vm_state/vars/main.yml

• 💣 💥 🔥 🚒 - Line 2, Col 32 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/create_security_group/defaults/main.yml

• 💣 💥 🔥 🚒 - Line 2, Col 42 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/create_security_group/handlers/main.yml

• 💣 💥 🔥 🚒 - Line 2, Col 42 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/create_security_group/meta/main.yml

• 💣 💥 🔥 🚒 - Line 57, Col 42 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/roles/create_security_group/tests/test.yml

• ⚠️ - Line 29, Col 1 - 1 > 0) (empty-lines - too many blank lines
• ⚠️ - Line 7, Col 5 - indentation - wrong indentation: expected 2 but found 4

content_tmp/ansible/roles/create_security_group/vars/main.yml

• 💣 💥 🔥 🚒 - Line 2, Col 38 - new-line-at-end-of-file - no new line character at the end of file

content_tmp/ansible/start_vm.yml

• ⚠️ - Line 9, Col 5 - indentation - wrong indentation: expected 2 but found 4

content_tmp/ansible/stop_vm.yml

• ⚠️ - Line 9, Col 5 - indentation - wrong indentation: expected 2 but found 4

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!