Create generic task notifications #17835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
generic-task-notifications
branch
from
d433e37 to
08a22f2
Compare
skateman
changed the title
Ladas
approved these changes
Aug 13, 2018
skateman
changed the title
skateman
force-pushed
the
generic-task-notifications
branch
from
08a22f2 to
9fba984
Compare
skateman
changed the title
|
Can't really test this until the |
skateman
force-pushed
the
generic-task-notifications
branch
from
9fba984 to
f15d021
Compare
skateman
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
skateman
force-pushed
the
generic-task-notifications
branch
from
f15d021 to
755930f
Compare
skateman
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
|
@skateman can you unwip this and rebase? I think this can get in |
skateman
force-pushed
the
generic-task-notifications
branch
from
755930f to
a999de5
Compare
skateman
changed the title
skateman
force-pushed
the
generic-task-notifications
branch
from
a999de5 to
b936ca8
Compare
|
Checked commits skateman/manageiq@2fd2c9a~...b936ca8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These notifications types are intended to be use with provider-initiated tasks when there is a need to notify the user about the progress. The
expires_inandaudiencevalues are just my assumptions and they might be wrong, this is one of the reasons why this is WIP.I also added helper methods for initiating these notifications from models, you just have to include the
NotificationMixinconcern and you can use thenotify_task(start|finish|fail|update)methods.If the last argument is omitted, the given record will be set as the notification subject automatically.
Related demo: ManageIQ/manageiq-providers-amazon#468
@miq-bot add_reviewer @martinpovolny