-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Amazon provider modal form demo #467
Conversation
+ gitignore node_modules
(cherry-picked from Hyperkid123/manageiq-ui-classic/b0c269da32fde4238475d1cc7f35bb3d6a36aa62)
and make it a string, we need to support all ids
Checked commits Hyperkid123/manageiq-providers-amazon@0d6cb28~...f6d0ed5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/helpers/manageiq/providers/amazon/toolbar_overrides/ems_cloud_center.rb
app/helpers/manageiq/providers/amazon/toolbar_overrides/x_vm_cloud_center.rb
|
This pull request has been automatically closed because it has not been updated for at least 6 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! |
Do not merge this is a demo
Continuing #460. Adds Redux controls for the form.
Controls
In order to avoid any bugs in current version, you can run a few commands from browser console.
Dependencies
This has a few dependencies in manageiq-ui-classic that need to be merged to make this working.Generic form buttons ManageIQ/manageiq-ui-classic#3509
For the latest version of the form component ManageIQ/react-ui-components#61 (and new version release)To enable direct import of css ManageIQ/manageiq-ui-classic#4326Some issues
Currently props cannot be passed to component inside modal. That can be fixed ni
modal.js
in ui-classic. @himdel knows about this. Therefore the providerId must be set in console first, before showing the modal.Importing css will also not work, if your webpack config does not have autoprefixer.
Also the API endpoint for creating is not available until #453 will be merged or rebase from that PR