Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Amazon provider modal form demo #467

Closed
wants to merge 7 commits into from

Conversation

Hyperkid123
Copy link

@Hyperkid123 Hyperkid123 commented Jul 20, 2018

Do not merge this is a demo

Continuing #460. Adds Redux controls for the form.

Controls

In order to avoid any bugs in current version, you can run a few commands from browser console.

ManageIQ.record.recordId = 'someId'
sendDataWithRx({controller: 'provider_dialogs', component_name: 'CreateAmazonSecurityGroupForm', modal_title: 'Create amazon provider.', props: {recordId: 'neco'}})

Dependencies

This has a few dependencies in manageiq-ui-classic that need to be merged to make this working.
Generic form buttons ManageIQ/manageiq-ui-classic#3509

For the latest version of the form component ManageIQ/react-ui-components#61 (and new version release)

To enable direct import of css ManageIQ/manageiq-ui-classic#4326

Some issues

Currently props cannot be passed to component inside modal. That can be fixed ni modal.js in ui-classic. @himdel knows about this. Therefore the providerId must be set in console first, before showing the modal.

Importing css will also not work, if your webpack config does not have autoprefixer.

Also the API endpoint for creating is not available until #453 will be merged or rebase from that PR

martinpovolny and others added 5 commits July 12, 2018 09:53
(cherry-picked from Hyperkid123/manageiq-ui-classic/b0c269da32fde4238475d1cc7f35bb3d6a36aa62)
and make it a string, we need to support all ids
@Hyperkid123
Copy link
Author

@himdel @martinpovolny

@miq-bot
Copy link
Member

miq-bot commented Jul 20, 2018

Checked commits Hyperkid123/manageiq-providers-amazon@0d6cb28~...f6d0ed5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 7 offenses detected

app/helpers/manageiq/providers/amazon/toolbar_overrides/ems_cloud_center.rb

  • ❗ - Line 18, Col 74 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 27, Col 74 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 28, Col 11 - Layout/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 7, Col 13 - Layout/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/manageiq/providers/amazon/toolbar_overrides/x_vm_cloud_center.rb

@miq-bot
Copy link
Member

miq-bot commented Jan 21, 2019

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants