-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E3SM-Project submodule #326
Conversation
TestingI ran the As expected, I'm seeing non-bit-for-bit changes in many Unfortunately, I'm also seeing non-bit-for-bit in a lot of other tests that shouldn't have been. All tests run successfully but the comparison fails for many:
On my Ubuntu laptop, the |
@sbrus89, I may need to bust out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the nightly suite on grizzly with both gnu and intel 19. I compared the commit just before the Redi column one (E3SM-Project/E3SM@11f02f2aa7) against the previous baseline on this PR (E3SM-Project/E3SM@44814ae) and the PASSED the comparison on all tests. So it looks like @xylar's intel test failure was due to something in his set-up.
Then I compared the head (E3SM-Project/E3SM@7b87d1fa) to just before the Redi column one (E3SM-Project/E3SM@11f02f2aa7) and the tests with Redi did not match, as expected:
00:10 PASS ocean_baroclinic_channel_10km_default
00:16 PASS ocean_baroclinic_channel_10km_threads_test
00:15 PASS ocean_baroclinic_channel_10km_decomp_test
00:17 PASS ocean_baroclinic_channel_10km_restart_test
00:41 PASS ocean_global_ocean_QU240_mesh
00:31 PASS ocean_global_ocean_QU240_PHC_init
00:31 FAIL ocean_global_ocean_QU240_PHC_performance_test
01:04 FAIL ocean_global_ocean_QU240_PHC_restart_test
01:02 FAIL ocean_global_ocean_QU240_PHC_decomp_test
01:03 FAIL ocean_global_ocean_QU240_PHC_threads_test
00:48 FAIL ocean_global_ocean_QU240_PHC_analysis_test
00:30 FAIL ocean_global_ocean_QU240_PHC_RK4_performance_test
01:04 FAIL ocean_global_ocean_QU240_PHC_RK4_restart_test
01:02 FAIL ocean_global_ocean_QU240_PHC_RK4_decomp_test
01:02 FAIL ocean_global_ocean_QU240_PHC_RK4_threads_test
00:00 PASS ocean_global_ocean_QUwISC240_mesh
00:00 PASS ocean_global_ocean_QUwISC240_PHC_init
00:33 FAIL ocean_global_ocean_QUwISC240_PHC_performance_test
00:33 PASS ocean_ice_shelf_2d_5km_z-star_restart_test
00:34 PASS ocean_ice_shelf_2d_5km_z-level_restart_test
00:15 PASS ocean_ziso_20km_default
00:13 PASS ocean_ziso_20km_with_frazil
but everything passed the execution.
On Chrysalis with Intel and Intel-MPI, comparing the updated E3SM-Project submodule with the current submodule as a baseline, I'm seeing:
So the expected results. I will test the same with OpenMPI (with both Intel and Gnu) but everything looks good. It seems like Intel and Intel-MPI on Anvil is just producing non-bit-for-bit results, whereas everywhere else is happy. I think we can let it be. |
@mark-petersen, thanks very much for testing and approving! |
Everything looks good on Chrysalis (with Intel and Intel-MPI; Intel and OpenMPI; and Gnu and OpenMPI). Merging... |
This merge updates the E3SM-Project submodule to match today's E3SM/master
Commit hash: 7b87d1faa545f7da4e792058401ad3bc04434c85
Merges of interest to compass:
closes #308