Fix non-standard declarations of 8-byte integers in ESMF in MPAS-Framework

[mark-petersen]

This PR fixes non-standard declarations of 8-byte integers in ESMF_BaseMod.F90. See the original PR for MPAS at MPAS-Dev/MPAS-Model#959.

The ESMF_BaseMod module contains several non-standard declarations of 8-byte
integer variables. These were identified using the GNU compiler:

   ESMF_BaseMod.F90:75:20:

      75 |           integer*8 :: ptr
         |                    1
   Error: GNU Extension: Nonstandard type declaration INTEGER*8 at (1)

and also using the NAG compiler:

   Error: ESMF_BaseMod.F90, line 75: KIND value (8) does not specify a valid representation method
   Error: ESMF_BaseMod.F90, line 163: KIND value (8) does not specify a valid representation method

Since the ESMF_BaseMod module already defines a parameter for selecting 8-byte
integers, namely, ESMF_KIND_I8, all that is needed is to move the definition of
this (and related) parameters to appear earlier in the module and to then use

   integer(kind=ESMF_KIND_I8)

rather than

   integer(kind=8)

[BFB]

[mark-petersen]

This passes MPAS-Ocean nightly regression suite with gnu and intel, both optimized and debug, and compares bfb with master.

[xylar]

This makes me wonder if it's worth trying to update the ESMF files to match the latest ESMF release at some point. Surely, these files are years and years out of date.

I guess this is probably a can of worms we don't want to open.

[rljacob]

This is a standalone, Fortran implementation of ESMF alarms and time management. It was never officially part of ESMF. The alternative is to build and link against ESMF itself. There's also a version in E3SM/share/esmf_wrf_timemgr

[philipwjones]

The ESMF time manager was probably the most expensive gold-plated time manager ever developed ;^) AFAIK, there have been no significant changes to that part of ESMF since it was first created, so this extracted standalone version should still be sufficient.

[philipwjones]

This is a straightforward and necessary change. Approve based on source code review and Mark's testing.

[jonbob]

passes sanity testing on chrysalis - merged to next

[mark-petersen]

FYI, also passes

SMS_D.T62_oQU120_ais20.MPAS_LISIO_TEST.cori-haswell_intel
SMS_D.T62_oQU120_ais20.MPAS_LISIO_TEST.cori-haswell_gnu

[jonbob]

merged to master