Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E3SM-Project to E3SM/master #383

Merged
merged 1 commit into from
May 7, 2022

Conversation

... as of 05/04/2022, commit d57fb310cbdcb10197a7aa29767976e3955f4475
@xylar xylar self-assigned this May 4, 2022
@xylar xylar requested a review from mark-petersen May 4, 2022 19:55
@xylar
Copy link
Collaborator Author

xylar commented May 5, 2022

Testing

I am doing tests on the new E3SM-Project submodule with the old one as a baseline on Anvil. Here are the ocean pr test suites I've run (checked means they completed):

  • intel impi - 21 tests are non-bit-for-bit
  • intel impi debug
  • intel openmpi
  • intel openmpi debug
  • intel mvapich - 3 tests fail execution (a known issue 3 ocean tests failing with intel and mvapich on Anvil #336)
  • intel mvapich debug - same 3 tests fail as above
  • gnu openmpi
  • gnu openmpi debug
  • gnu mvapich
  • gnu mvapich debug

@xylar
Copy link
Collaborator Author

xylar commented May 5, 2022

I investigated the non-bit-for-bit changes on Anvil with Intel and Intel-MPI. They are small (machine precision) and can be traced to E3SM-Project/E3SM#4472 (using #354). I recommend we don't try to do anything about them. This particular combination has been a problem before for us (e.g. #326 (comment)).

@xylar xylar requested a review from sbrus89 May 5, 2022 00:17
@xylar
Copy link
Collaborator Author

xylar commented May 5, 2022

@sbrus89, I'm flagging you to review because this brings in E3SM-Project/E3SM#4472 and just wanted to see if you want to double check that it's actually there as expected.

@mark-petersen, could you maybe run some tests on a machine other than Anvil? You could test out the matrix build utility if you want. Or just build by hand as usual.

Copy link
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with gnu on grizzly with the nightly suite, and I get bfb on all tests between the two submodule hashes. Thanks!

@xylar
Copy link
Collaborator Author

xylar commented May 7, 2022

Thanks @mark-petersen.

@xylar xylar removed the request for review from sbrus89 May 7, 2022 14:34
@xylar
Copy link
Collaborator Author

xylar commented May 7, 2022

@sbrus89, I'm taking you off as a reviewer because I think this has been tested plenty. But this should mean #348 is closer to ready.

@xylar xylar merged commit db89465 into MPAS-Dev:master May 7, 2022
@xylar xylar deleted the update_e3sm_project branch May 7, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants