GPU port of thickness tendency with OpenACC #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace mesh pool variables and arrays with counterparts in ocn_mesh module - remove meshPool from ocn_tend_thick subroutine calls in time integrator routines
- resolve OpenACC error in mpas_ocn_diagnostics.F by copying needed arrays onto device in ocn_compute_land_ice_flux_input_fields routine - add OpenACC directives to loops in ocn_tend_thick and associated subroutines - copyout tendThick, surfaceThicknessFlux, and surfaceThicknessFluxRunoff back to host at end of ocn_tend_thick
philipwjones
approved these changes
Feb 18, 2022
|
@philipwjones, thanks very much for testing with compass! |
mark-petersen
approved these changes
Feb 20, 2022
There was a problem hiding this comment.
This now matches bfb for nightly suite with both gnu and intel between the branch point for #4785 (bc5a2cc) and the head of #4785, plus these two commits cherry-picked on top. That was the easiest way to make a clean comparison. I also tested the head of this PR with gnu and intel 19, optimized and debug, and it passed everything. I also looked through the code, and tested head with:
SMS_D.T62_oQU120_ais20.MPAS_LISIO_TEST.cori-haswell_gnu
SMS_D.T62_oQU120_ais20.MPAS_LISIO_TEST.cori-haswell_intel
@brian-oneill thanks for fixing these problems, and the clean-up of removing the mesh pool.
jonbob
added a commit
that referenced
this pull request
Feb 22, 2022
) GPU port of thickness tendency with OpenACC GPU port of ocn_tend_thick and all subprocesses. Changes include: * replace mesh pool variables and arrays with counterparts in ocn_mesh module * remove meshPool from ocn_tend_thick subroutine calls in time integrator routines * resolve OpenACC error in mpas_ocn_diagnostics.F by copying needed arrays onto device in ocn_compute_land_ice_flux_input_fields routine * add OpenACC directives to loops in ocn_tend_thick and associated subroutines [BFB]
|
Passes the following e3sm_developer tests on chrysalis:
Merged to next |
|
merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPU port of ocn_tend_thick and all subprocesses
Changes include:
Bit-for-bit for QU240 test problem with PGI on Summit in CPU-only and GPU builds. Passed compass PR suite on Chrysalis with Intel/IMPI and GNU/OpenMPI
[BFB]