Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Italian localization #533

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Added Italian localization #533

merged 1 commit into from
Jun 11, 2023

Conversation

andreaippo
Copy link
Contributor

Added Italian localization

@MV-GH
Copy link
Collaborator

MV-GH commented Jun 11, 2023

The pipeline fails at <string name="login_view_model_is_not_a_lemmy_instance">%1$s non è un'istanza Lemmy</string>

Possibly due to the '

@andreaippo
Copy link
Contributor Author

The pipeline fails at <string name="login_view_model_is_not_a_lemmy_instance">%1$s non è un'istanza Lemmy</string>

Possibly due to the '

Thanks. On it!

@Krusty27
Copy link

Hi, actually we were already talking on how to translate in Italian here (on Feddit.it, an italian Lemmy instance). Join us if you wish

@twizmwazin twizmwazin merged commit d8c65f7 into LemmyNet:main Jun 11, 2023
@andreaippo
Copy link
Contributor Author

Hi, actually we were already talking on how to translate in Italian here (on Feddit.it, an italian Lemmy instance). Join us if you wish

Hey,
Just saw this, but now my PR got merged.

Not a big deal, I guess you guys can just open follow-up PRs for stuff you'd like to propose to change.

Before starting working on this I've searched for open PRs with Italian in the title and couldn't find any.
That's why in the future I would suggest to start by opening a PR in Draft status, it's much easier for anyone to find (and comment). 😉

@andscape-dev
Copy link
Contributor

andscape-dev commented Jun 13, 2023

Hi @andreaippo, thanks for this! I've pushed updates to the translations in #591 as you suggested. My fault for not creating a draft beforehand while I was working on it. If you have time to review the changes it'd be awesome.

In the future, you're welcome to join us on Feddit.it to discuss Italian language-related changes before merging. :)

dessalines added a commit that referenced this pull request Jun 20, 2023
* fix: Comment replies icon appears in profile #533

* feat: go to comment on click (profile, inbox), mark as read (inbox) #745

---------

Co-authored-by: Dessalines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants