Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Italian Translations #591

Merged
merged 13 commits into from
Jun 13, 2023
Merged

Conversation

andscape-dev
Copy link
Contributor

Update the translations to Italian added by @andreaippo in #533, based on discussions with the community on Feddit.it (thread).

Notable updates:

  • Attempt to remove gendered nouns for users
  • Standardize capitalization for UI elements
  • Fix gender suffixes (ex: "Tutte" -> "Tutti" for Posts)
  • Fix specific strings based on user feedback from thread (ex: "Mostra Sorgente" -> "Mostra Markdown")
  • Add translations for strings added in recent commits

<string name="markdownHelper_formatItalic">Formatta in Corsivo</string>
<string name="markdownHelper_insertQuote">Inserisci Citazione</string>
<string name="markdownHelper_insertList">Inserisci Lista</string>
<string name="markdownHelper_insertHeader">Insericsci Titolo</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InseriCsci -> Inserisci

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

<string name="markRead">Segna Come Già Letto</string>
<string name="markUnread">Segna Come Non Letto</string>
<string name="comment_save">Salva Commento</string>
<string name="comment_unsave">De-salva Commento</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? De-salva is unheard of. Maybe Annulla Modifiche? Or Ignora Commento?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, de-salva sucks hahah, I couldn't come up with a better opposite for "salvare". "Ignora Commento" could work, but I'm not sure it's clear to users that it unsaves a comment...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see maybe, this is to "star" a comment for finding it back later on?
I though it had to do with comment editing features instead, hence my proposal to go with "Ignora".
How about "Rimuovi da commenti salvati"?

<string name="removeBookmark">Rimuovi Dai Segnalibri</string>
<string name="commentFooter_reply">Rispondi A Questo Commento</string>
<string name="dialog_moreOptions">Mostra Più Opzioni</string>
<string name="pickImage_imagePreview">Anteprima dell\' Immagine Caricata</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space after apostrophe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

<string name="bottomBar_communityList">Vai Alla Lista Delle Comunità</string>
<string name="bottomBar_bookmarks">Vai Ai Miei Segnalibri</string>
<string name="bottomBar_profile">Vai Al Mio Profilo</string>
<string name="bottomBar_inbox">Vai Alla Mia Inbox</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You renamed this to Posta In Arrivo earlier, but now it's Inbox again, so which one is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed using Posta in Arrivo everywhere

<string name="sorttype_active">Attivi</string>
<string name="sorttype_hot">Di tendenza</string>
<string name="sorttype_old">Old</string>
<string name="sorttype_hot">Di Tendenza</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed this in an earlier occurrence, to translate as "Popolari". Which is fine by me.
But here it's "Di Tendenza" again, which is inconsistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed using Popolari

<string name="look_and_feel_use_custom_tabs">Usa schede personalizzate</string>
<string name="settings_activity_settings">Impostazioni</string>
<string name="settings_activity_look_and_feel">Aspetto</string>
<string name="settings_activity_look_and_feel">Aspetto Interfaccia</string>
<string name="settings_activity_account_settings">%1$s impostazioni</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing capitalization for Impostazioni

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

<string name="look_and_feel_look_and_feel">Aspetto</string>
<string name="look_and_feel_font_size">Dimensione carattere: %1$s</string>
<string name="look_and_feel_font_size">Grandezza font: %1$s</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see various changes to replace leftover yet very popular English words with their Italian counterpart (e.g. Inbox, which you changed to Posta In Arrivo, Community to Comunità, and so on).
Yet here you do the opposite, prefering Font over Carattere. We should try and be more consistent.

I need to get some inspiration from other apps, but for example Android translates this, in the system Settings, as "Dimensioni (plural) carattere". So yeah, I'd rather go back to the previous translation here, maybe turning dimensione into plural form.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with undoing the change. "Dimensioni" though seems wrong, since it's referring to a single value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then back to Dimensione Carattere is fine by me

<string name="account_settings_show_notifications_for_new_posts">Invia Notifiche per Nuovi Post</string>
<string name="account_settings_send_notifications_to_email">Invia Notifiche via Email</string>
<string name="account_settings_save_settings">Salva Impostazioni</string>
<string name="account_settings_activity_account_settings">Impostazioni Account</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a previous translation you replace account with profilo, but here it's account again. Which one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed using Profilo everywhere

<string name="account_settings_mostcomments">Più commenti</string>
<string name="account_settings_newcomments">Nuovi commenti</string>
<string name="account_settings_default_sort_type">Ordinamento predefinito</string>
<string name="account_settings_topday">TopGiorno</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are values for a drop-down. While I know that in English there's no spacing to separe multiple words at this location, I wonder if that's a glitch, and what would be the problem with using spaces to separate words here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it to expand the strings. Tested it in Android Studio and it seems to work fine...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I wonder if you'd feel like opening a MR on the original (English) strings as well, maybe it's indeed a glitch by the dev ;)

Copy link
Contributor

@andreaippo andreaippo Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work, you caught a few slips here and there as well. 👍
In general, though, I can't say I'm a fan of capitalizing every noun and sometimes even articles?
It's not the practice of our language (as opposed to, say, German).
I would much rather prefer capitalizing the first letter of a sentence and be done with it, also to reduce visual clutter.
I'm currently on my mobile and the first app I have at hand (Firefox) doesn't do this neither (e.g. Salva in una raccolta, Aggiungi alle scorciatoie)

@Magneticdud
Copy link

<string name="markdownHelper_formatStrikethrough">Formatta ComeTesto Barrato</string> manca lo spazio

Ma perché ogni parola è maiuscola? Per esempio <string name="bottomBar_communityList">Vai Alla Lista Delle Comunità</string>.

La Leggibilità Nel Caso Ogni Parola Sia Maiuscola Mi Pare Inferiore. A Meno Che Non Sia Una Scelta Stilistica Dell'App Che Si Riflette Anche Nelle Altre Lingue, In Italiano, Solo I Nomi Propri Si Scrivono In Maiuscolo

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I hold off on merging this until everyone's satisfied? Or would everyone prefer to merge this, then do additional PRs for small fixes?

@andreaippo
Copy link
Contributor

andreaippo commented Jun 13, 2023

Should I hold off on merging this until everyone's satisfied? Or would everyone prefer to merge this, then do additional PRs for small fixes?

Hey, while I still have some remarks, I'm personally a fan of the "done is better than perfect" approach.
So if the others also agree I'd say merge it.
We can keep discussing our different POVs on this MR, and depending on the outcome open a small follow-up one.

@andscape-dev what do you think, author? :)
If OK for you, pls also notice that a rebase is needed

@andreaippo
Copy link
Contributor

<string name="markdownHelper_formatStrikethrough">Formatta ComeTesto Barrato</string> manca lo spazio

Ma perché ogni parola è maiuscola? Per esempio <string name="bottomBar_communityList">Vai Alla Lista Delle Comunità</string>.

La Leggibilità Nel Caso Ogni Parola Sia Maiuscola Mi Pare Inferiore. A Meno Che Non Sia Una Scelta Stilistica Dell'App Che Si Riflette Anche Nelle Altre Lingue, In Italiano, Solo I Nomi Propri Si Scrivono In Maiuscolo

Concordo, ed è il commento che ho fatto anch'io qui:

#591 (comment)

@andscape-dev
Copy link
Contributor Author

Thanks @andreaippo for the review! I've fixed most of the issues you pointed out, let me know if we can resolve the convos. I haven't changed "de-salva" yet, can we come up with a clearer solution?

For the capitalization I don't have a strong opinion. I do prefer capitalization for UI labels, since for me they're closer to titles than body text, but that might be because I'm used to English locales. It's also used in the English version of Jerboa, even though English grammar doesn't require capitalizing nouns. However, if it's standard not to capitalize labels in the Italian locale, we can revert to that format. I would say let's keep this for another PR though.

@andreaippo
Copy link
Contributor

Thanks @andreaippo for the review! I've fixed most of the issues you pointed out, let me know if we can resolve the convos. I haven't changed "de-salva" yet, can we come up with a clearer solution?

For the capitalization I don't have a strong opinion. I do prefer capitalization for UI labels, since for me they're closer to titles than body text, but that might be because I'm used to English locales. It's also used in the English version of Jerboa, even though English grammar doesn't require capitalizing nouns. However, if it's standard not to capitalize labels in the Italian locale, we can revert to that format. I would say let's keep this for another PR though.

Indeed let's try to address the ugly de-salva first LOL
As for capitalization, as @Magneticdud and I said in other comments, it looks clunky and out of place in Italian apps. Any Android app I'm opening now (Gmail, Pixel dialer) further backs this position. But I agree about handling this in another MR ;)

@andscape-dev
Copy link
Contributor Author

@andreaippo How about "scarta" instead of de-salva? Gives the idea of something you have and want to throw away...

@andscape-dev
Copy link
Contributor Author

@dessalines I think we're ready

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmk great!

@dessalines dessalines enabled auto-merge (squash) June 13, 2023 14:15
@dessalines dessalines merged commit 8c66f97 into LemmyNet:main Jun 13, 2023
@andscape-dev andscape-dev deleted the localization-it branch July 12, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants