-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Comment replies icon appears in profile #533 #726
fix: Comment replies icon appears in profile #533 #726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a merge from main, but also I don't understand the point of this. We recently allowed replying to your own comment, so that should be okay.
Currently, when you click on a comment from the profile section, when it has replies, it "collapses" like it would in the post section. Now why that's an issue - when you collapse a comment, it shows a number of how many comments were collapsed. The comments don't show and aren't collapsed in the profile section, but the number of "collapsed" comments still shows. Can get you a quick vid of the issue if needed. It's not that big of an issue, but refactoring it like this allows for custom comment onClicks depending on where the component's used. Allowing for a simple implenentation of things like this #745 |
Ah I see what you're saying, gotcha. The click in that case should really show the context (same for inbox) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
#553