Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align master with P1 #6

Merged
merged 108 commits into from
May 23, 2024
Merged

Align master with P1 #6

merged 108 commits into from
May 23, 2024

Conversation

fbeutin-ledger
Copy link

No description provided.

ajinkyaraj-23 and others added 30 commits January 5, 2024 13:57
…-confirm-reject-screen-to-blindsigning

Add reject confirm screen for blindsigning flow
…ignore-extra-id-param

Swap: do not check extra_id param anymore
…reveal-transaction

Swap: allow one reveal before the transaction
app-exchange workflow was updated to allow overriding of app repo
…exchange

CI: use default app-exchange repo
- ledger-sdk version changed to 3.12.0
- It resulted in nanosp sdk version change.
- Nanosp snapshots updated due to change in font used in SDK
…dger_sdk_version

upgrade ledger sdk version
 - tz_operation_descriptor to tz_operation_field_descriptor
 - field to field_index
 - Use designated initializers notation: { .field=value }, this allows:
   - to have default value to false for the fields skip and complex
   - to make it easier to read
 - Use "_" in front of unused name
…t-mode-splash-screen-before-parameter

Add an expert mode splash screen before the parameter field of the transaction operation
spalmer25 and others added 28 commits February 14, 2024 16:08
Co-authored-by: Ajinkya Rajandekar <[email protected]>
if items other than the first are defined
…entation-for-the-parser

Documentation: add documentation for parser files
…e-oxford-changes

Parser: handle Oxford changes
…umentation

Add documentation for streaming and display related functions
- script to run tests needs to be changed due to updated docker container
- change readme to reflect new way of running the tests.
…-blindsign-enabled-splash-screen

Fix blindsign enabled splash screen
* @return tz_parser_result: parser result
*/
static tz_parser_result
tz_step_field(tz_parser_state *state)

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 180 lines.
@fbeutin-ledger fbeutin-ledger merged commit 40e76d4 into main May 23, 2024
137 of 138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants