Add an expert mode splash screen before the parameter field of the transaction operation #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalmer25
added
bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
spalmer25
force-pushed
the
palmer@functori@expert-mode-splash-screen-before-parameter
branch
2 times, most recently
from
379b2fa to
64c9c5b
Compare
spalmer25
force-pushed
the
palmer@functori@expert-mode-splash-screen-before-parameter
branch
5 times, most recently
from
d129564 to
8619e03
Compare
ajinkyaraj-23
approved these changes
Jan 12, 2024
emturner
reviewed
Jan 12, 2024
| TZ_OPERATION_FIELD("Destination", TZ_OPERATION_FIELD_DESTINATION), | ||
| TZ_OPERATION_OPTION_FIELD("_Parameters", | ||
| TZ_OPERATION_TUPLE_FIELD("_Parameters", | ||
| TZ_OPERATION_FIELD("Entrypoint", TZ_OPERATION_FIELD_SMART_ENTRYPOINT, .complex=true), |
There was a problem hiding this comment.
I think Entrypoint can be made complex=false 😄
There was a problem hiding this comment.
I agree, let's do it in another PR: #194
- tz_operation_descriptor to tz_operation_field_descriptor - field to field_index
spalmer25
force-pushed
the
palmer@functori@expert-mode-splash-screen-before-parameter
branch
2 times, most recently
from
21567e5 to
64bd107
Compare
| * information | ||
| */ | ||
| static tz_parser_result | ||
| tz_step_field(tz_parser_state *state) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
- Use designated initializers notation: { .field=value }, this allows:
- to have default value to false for the fields skip and complex
- to make it easier to read
- Use "_" in front of unused name
spalmer25
force-pushed
the
palmer@functori@expert-mode-splash-screen-before-parameter
branch
from
64bd107 to
80762b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #175