Security Audit passed #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplay-of-expert-mode-enabled Change "Expert Mode Enabled" screen to match "TRANSACTION SIGNED" format
…dit-tests Tests: fix failing tests at app-builder version 3.15.0
[misra-c2012-8.2] Function types shall be in prototype form with named parameters
[misra-c2012-7.2] A "u" or "U" suffix shall be applied to all integer constants that are represented in an unsigned type
[misra-c2012-13.4] The result of an assignment operator should not be used
[misra-c2012-15.6] The body of an iteration-statement or a selection-statement shall be a compound-statement
[misra-c2012-12.1] The precedence of operators within expressions should be made explicit
to prevent it from being included twice
…yle-weaknesses Style: handle code style weaknesses
APPLICATION_FLAG_GLOBAL_PIN, APPLICATION_FLAG_BOLOS_SETTINGS
…d-ledger-flags Remove unused Ledger flags
…for-new-entrypoints-introduced-in-oxford-2 Add new Oxford2 entrypoints
…-if-we-dont-return-the-hash Address audit report comments
…sts-at-latest-app-builder-version Test: fix failing tests at latest app builder version
Co-authored-by: Ajinkya Rajandekar <[email protected]>
if items other than the first are defined
CodeQL: fix some code quality
…for-the-parser Documentation: add documentation for parser files
…changes Parser: handle Oxford changes
Add documentation for streaming and display related functions
- script to run tests needs to be changed due to updated docker container - change readme to reflect new way of running the tests.
…n-enabled-splash-screen Fix blindsign enabled splash screen
Sync with Ledger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following features are added: