Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeQL: fix some code quality #221

Merged
merged 3 commits into from
Feb 16, 2024
Merged

CodeQL: fix some code quality #221

merged 3 commits into from
Feb 16, 2024

Conversation

spalmer25
Copy link
Collaborator

@spalmer25 spalmer25 commented Feb 14, 2024 •
edited
Loading

  • Explicit functions
  • Explicit enum value
  • Split to complex switch

@spalmer25 spalmer25 self-assigned this Feb 14, 2024
@spalmer25 spalmer25 marked this pull request as ready for review February 15, 2024 09:28
ajinkyaraj-23
ajinkyaraj-23 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit 4c04d78 into main Feb 16, 2024
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajinkyaraj-23 ajinkyaraj-23 ajinkyaraj-23 approved these changes

@emturner emturner Awaiting requested review from emturner

Assignees

@spalmer25 spalmer25

Labels
None yet
Projects
None yet
Milestone
Wallet: v3.0.3 - security audit
Development

Successfully merging this pull request may close these issues.
2 participants
@spalmer25 @ajinkyaraj-23