-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtype: avoid some false alarm in subtype_unionall
#47868
Conversation
@nanosoldier |
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
The current check is not correct if we set the typevar's bounds to an unwrapped `UnionAll`. Use `var_occurs_inside_skip` to skip the inside check.
This reverts commit b5f7982.
Also add `env` test.
Failure in |
@nanosoldier |
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
The result looks good. The only concern is Since the "Segmentation fault" was happened in libmosek64, I thought this PR might be unrelated? cc @blegat @ulfworsoe |
I would assume it is not related to this PR Indeed, @ulfworsoe might know better where this crash is coming from, see https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/2bac38a_vs_b6f32bc/MosekTools.primary.log |
As I look further into this, I think the concept of My current theory is that we need to instead deal with this by setting the var in the env to something unsatisfyable (either with a bit, or with a falsifiable constraint such as |
@blegat It is possible that the crash is solely a MOSEK issue. I don't see how it would be related to a anything on the Julia side, unless it's a memory corruption. We have also seen segfaults when allocation fails, e.g. if a memory limit was set with ulimit. |
I may have a fix for #47658 that also fixes these cases. |
The current check is not correct if we set the typevar's bounds to an unwrapped
UnionAll
. Usevar_occurs_inside_skip
to skip the inside check.close #24333, close #47654