intersect: fix a minor soundness issue with supertypes #47813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
When doing intersection, we might end up with a value in `env` (as the only possible *value* for that parameter) without properly considering that the parameter might be a TypeVar.
vtjnash
force-pushed
the
jn/overintersect_super
branch
from
666aeb0 to
38f1fbe
Compare
vtjnash
added
the
needs pkgeval
26 tasks
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
|
BitArrays issue should be fixed by #47830, rest seem to look like flaky package tests Ripserer may need investigation |
|
@nanosoldier |
JeffBezanson
approved these changes
Dec 15, 2022
vtjnash
added
merge me
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
KristofferC
pushed a commit
that referenced
this pull request
Dec 16, 2022
When doing intersection, we might end up with a value in `env` (as the only possible *value* for that parameter) without properly considering that the parameter might be a TypeVar. (cherry picked from commit 26a7dbb)
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing intersection, we might end up with a value in
env(as the only possible value for that parameter) without properly considering that the parameter might be a TypeVar.