Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #30741, fix #31082, stack overflow in type intersection #31167

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added types and dispatch Types, subtyping and method dispatch bugfix This change fixes an existing bug labels Feb 25, 2019
@mortenpi
Copy link
Contributor

I can verify that it fixes the example @jagot posted in #30741 (comment)

@vtjnash
Copy link
Member

vtjnash commented Dec 19, 2022

IIUC, this PR is partly falsifiable with the following counter-example. Do you remember the context of this PR? The commit notes seem to contain very little information beyond fixes ###

julia> T = Tuple{Union{Type{T}, Type{S}}, Union{Val{T}, Val{S}}, Union{Val{T}, S}} where T<:Val{A} where A where S<:Val
Tuple{Union{Type{T}, Type{S}}, Union{Val{T}, Val{S}}, Union{Val{T}, S}} where {S<:Val, A, T<:Val{A}}

julia> S = Tuple{Type{T}, T, Val{T}} where T<:(Val{S} where S<:Val)
Tuple{Type{T}, T, Val{T}} where T<:(Val{S} where S<:Val)

julia> typeintersect(S,T)
Union{}

julia> Tuple{Type{Val{Val{Int}}}, Val{Val{Int}}, Val{Val{Val{Int}}}} <: S
true

julia> Tuple{Type{Val{Val{Int}}}, Val{Val{Int}}, Val{Val{Val{Int}}}} <: T
true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug types and dispatch Types, subtyping and method dispatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants