Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subtyping regression #24333

Closed
JeffBezanson opened this issue Oct 25, 2017 · 4 comments
Closed

subtyping regression #24333

JeffBezanson opened this issue Oct 25, 2017 · 4 comments
Assignees
@JeffBezanson
Labels
bug Indicates an unexpected problem or unintended behavior types and dispatch Types, subtyping and method dispatch

Comments

@JeffBezanson
Copy link
Member 

julia> Type{Union{Int,Void}} <: Type{Union{T,Void}} where T
true

julia> Type{Union{Ref,Void}} <: Type{Union{T,Void}} where T
false

Both are true in 0.6. Probably an artifact of one of the recent subtyping fixes.
@JeffBezanson JeffBezanson added regression Regression in behavior compared to a previous version types and dispatch Types, subtyping and method dispatch labels Oct 25, 2017
@JeffBezanson JeffBezanson self-assigned this Oct 25, 2017
@JeffBezanson JeffBezanson mentioned this issue Apr 4, 2018
Open
@tkf tkf mentioned this issue Jan 18, 2019
Open
JeffBezanson added a commit that referenced this issue Jun 26, 2019
@JeffBezanson
fix #32386, type intersection bug in var bounds
eae671e 
might be related to #24333 and/or #21153
@JeffBezanson JeffBezanson mentioned this issue Jun 26, 2019
Merged
JeffBezanson added a commit that referenced this issue Jun 27, 2019
@JeffBezanson
fix #32386, type intersection bug in var bounds (#32425)
0d9c72d 
might be related to #24333 and/or #21153
JeffBezanson added a commit that referenced this issue Jun 27, 2019
@JeffBezanson
fix #32386, type intersection bug in var bounds (#32425)
05e78d5 
might be related to #24333 and/or #21153
(cherry picked from commit 0d9c72d)
@oscardssmith
Copy link
Member

oscardssmith commented Dec 7, 2020 •
edited
Loading

fixed on master. Edit no it's not. I misread this horribly.

@KristofferC
Copy link
Member

Should have a test before close

@KristofferC KristofferC reopened this Dec 8, 2020
@KristofferC KristofferC added the needs tests Unit tests are required for this change label Dec 8, 2020
oscardssmith added a commit to oscardssmith/julia that referenced this issue Dec 8, 2020
@oscardssmith
Add test for JuliaLang#24333
5bed954 
JuliaLang#24333
@oscardssmith oscardssmith mentioned this issue Dec 8, 2020
Merged
JeffBezanson pushed a commit that referenced this issue Dec 9, 2020
@oscardssmith
Add test_broken for #24333 (#38769)
97266be
@vtjnash vtjnash added bug Indicates an unexpected problem or unintended behavior and removed needs tests Unit tests are required for this change regression Regression in behavior compared to a previous version labels Jan 30, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this issue May 4, 2021
@oscardssmith @ElOceanografo
Add test_broken for JuliaLang#24333 (JuliaLang#38769)
b726b0d
@brenhinkeller
Copy link
Contributor

brenhinkeller commented Nov 19, 2022 •
edited
Loading

Still happening in 1.8 and 1.9:

julia> Type{Union{Int,Nothing}} <: Type{Union{T,Nothing}} where T
true

julia> Type{Union{Ref,Nothing}} <: Type{Union{T,Nothing}} where T
false

julia> versioninfo()
Julia Version 1.9.0-alpha1
Commit 0540f9d7394 (2022-11-15 14:37 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin21.5.0)
  CPU: 10 × Apple M1 Max
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, westmere)
  Threads: 1 on 10 virtual cores

N5N3 added a commit to N5N3/julia that referenced this issue Dec 10, 2022
@N5N3
subtype fix1
87ddaaf 
close JuliaLang#47654 JuliaLang#24333
@N5N3 N5N3 mentioned this issue Dec 11, 2022
Closed
@vtjnash
Copy link
Member

vtjnash commented Jan 24, 2023

@JeffBezanson this returns the correct answer now. can you close it?

@vtjnash vtjnash closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
bug Indicates an unexpected problem or unintended behavior types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Subtype: avoid some false alarm in subtype_unionall N5N3/julia
5 participants
@vtjnash @JeffBezanson @KristofferC @brenhinkeller @oscardssmith