Extraction of Globals.prefs.put and .get #7121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/master: (36 commits) Fix remembering password for sql db (#7154) Update to libre office 7.0.3 (#7150) Add IdBasedSearchFetcher to jstor (#7145) Squashed 'src/main/resources/csl-styles/' changes from 55200d0..a20406d Bump antlr4-runtime from 4.8-1 to 4.9 (#7136) Bump antlr4 from 4.8-1 to 4.9 (#7138) Bump mariadb-java-client from 2.7.0 to 2.7.1 (#7134) Bump classgraph from 4.8.90 to 4.8.92 (#7139) Bump mockito-core from 3.6.0 to 3.6.28 (#7135) Bump gittools/actions from v0.9.6 to v0.9.7 (#7144) Bump checkstyle from 8.37 to 8.38 (#7142) Add missing author Fix document viewer not showing first page (#7132) Add githandler mock to crawler test to fix NPE (#7133) Searchbar glyph icon colors in Dark Theme [FIXED] (#7131) Fix binding issue for the regex and case sensitive search buttons (#7125) Enable automated cross library search using a cross library query lan… (#7124) Add tracking Update Java Version Welcome Dominik ✌ ...
|
I added some further extractions and removed some calls to JabRefPreferences.getInstance(). TODO: We need some kind of MrDlib Preferences for SEND_LANGUAGE_DATA etc. |
…ary calls to Globals
Siedlerchr
reviewed
Dec 6, 2020
|
We should wait with merging until #6187 to prevent merge conflicts |
…calls to JabRefPreferences
# Conflicts: # src/main/java/org/jabref/gui/copyfiles/CopySingleFileAction.java # src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.java
|
This is definitely enough... Next step will be to extract all the calls to |
|
The localization consistency tests are parsing comments too... |
calixtus
added
the
status: ready-for-review
|
Can you test #7147 as well? Seems like also it's related to the prefs somehow |
Siedlerchr
reviewed
Dec 10, 2020
| ClipBoardManager.clipboard = clipboard; | ||
| ClipBoardManager.primary = primary; | ||
| ClipBoardManager.importFormatReader = importFormatReader; | ||
|
|
There was a problem hiding this comment.
I guees Tobi or Olli will complain about the empty space ;)
Suggested change
There was a problem hiding this comment.
No here it's fine...just don't add empty lines at the beginning or end of a method
tobiasdiez
approved these changes
Dec 13, 2020
|
Something's off with the tests. I'll look into it |
Siedlerchr
reviewed
Dec 14, 2020
Siedlerchr
added a commit
that referenced
this pull request
Dec 21, 2020
* upstream/master: (33 commits) Bump archunit-junit5-api from 0.14.1 to 0.15.0 (#7220) Bump unoloader from 7.0.3 to 7.0.4 (#7214) Bump guava from 30.0-jre to 30.1-jre (#7218) Bump xmpbox from 2.0.21 to 2.0.22 (#7217) Bump classgraph from 4.8.94 to 4.8.97 (#7211) Bump byte-buddy-parent from 1.10.18 to 1.10.19 (#7216) Bump archunit-junit5-engine from 0.14.1 to 0.15.0 (#7215) Bump org.beryx.jlink from 2.22.3 to 2.23.0 (#7212) Add missing author Remove field check for journal abbrev in entry editor (#7208) Improvements for Entry Preview (in the context of #7083 and in addition to #7093) (#7185) Fix pdf content importer exception if DOI is empty (#7207) New translations JabRef_en.properties (Turkish) (#7204) New Crowdin updates (#7198) New Crowdin updates (#7192) Added missing test Changed tests to parameterized tests Extraction of Globals.prefs.put and .get (#7121) Fix newly added entry not synced to db (#7178) Bump org.eclipse.jgit from 5.9.0.202009080501-r to 5.10.0.202012080955-r (#7187) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to extract the calls to Globals.prefs.put and .get out of the JabRef codebase in preparation for some architectural healing...