Fix newly added entry not synced to db #7178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newly added entries have empty fields; don't update the field table to prevent SQL Exception Fix shared entry not found by id use left outer join for this
Siedlerchr
added
the
status: ready-for-review
|
I don't know why the documentation test fails |
tobiasdiez
requested changes
Dec 13, 2020
| } | ||
| } | ||
|
|
||
| Map<String, String> expectedFieldMap = expectedEntry.getFieldMap().entrySet().stream().collect(Collectors.toMap((entry) -> entry.getKey().getName(), Map.Entry::getValue)); |
There was a problem hiding this comment.
Isn't this always an empty list (as expected entry is empty)?
There was a problem hiding this comment.
Hm, seems like I need to adapt the queries a bit. Didn't think about this,
I should check for the shared entry id to be present.
There was a problem hiding this comment.
To be honest, I've no idea what the test is doing. You add an empty entry, then some other completely unrelated entry, and then compare against the empty entry again.
koppor
reviewed
Dec 14, 2020
Siedlerchr
added a commit
that referenced
this pull request
Dec 21, 2020
* upstream/master: (33 commits) Bump archunit-junit5-api from 0.14.1 to 0.15.0 (#7220) Bump unoloader from 7.0.3 to 7.0.4 (#7214) Bump guava from 30.0-jre to 30.1-jre (#7218) Bump xmpbox from 2.0.21 to 2.0.22 (#7217) Bump classgraph from 4.8.94 to 4.8.97 (#7211) Bump byte-buddy-parent from 1.10.18 to 1.10.19 (#7216) Bump archunit-junit5-engine from 0.14.1 to 0.15.0 (#7215) Bump org.beryx.jlink from 2.22.3 to 2.23.0 (#7212) Add missing author Remove field check for journal abbrev in entry editor (#7208) Improvements for Entry Preview (in the context of #7083 and in addition to #7093) (#7185) Fix pdf content importer exception if DOI is empty (#7207) New translations JabRef_en.properties (Turkish) (#7204) New Crowdin updates (#7198) New Crowdin updates (#7192) Added missing test Changed tests to parameterized tests Extraction of Globals.prefs.put and .get (#7121) Fix newly added entry not synced to db (#7178) Bump org.eclipse.jgit from 5.9.0.202009080501-r to 5.10.0.202012080955-r (#7187) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7176
Should also fix #6944
Newly added entries have empty fields; don't update the field table to prevent SQL Exception
Fix shared entry not found by id
use left outer join for this